New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Thomas HDX relies on fast_normalise rounding errors #869

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
3 participants
@ulteq
Contributor

ulteq commented May 3, 2016

No description provided.

@ulteq ulteq merged commit ba71671 into RigsOfRods:master May 3, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ulteq ulteq deleted the ulteq:fast_normalise-revert branch May 3, 2016

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur May 4, 2016

Contributor

what is this supposed to fix?

Contributor

Hiradur commented May 4, 2016

what is this supposed to fix?

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr May 5, 2016

Member

@Hiradur From our Gitter chatroom:

Ulteq:
@only-a-ptr You were right: #863 (comment) 😄
The little change I did, screwed the Thomas HDX up again.
I looks like some trucks rely on the rounding errors that fast_normalise produces. 😞
I fixed it, and I won't ever touch fast_normalise again. ^^

Member

only-a-ptr commented May 5, 2016

@Hiradur From our Gitter chatroom:

Ulteq:
@only-a-ptr You were right: #863 (comment) 😄
The little change I did, screwed the Thomas HDX up again.
I looks like some trucks rely on the rounding errors that fast_normalise produces. 😞
I fixed it, and I won't ever touch fast_normalise again. ^^

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur May 5, 2016

Contributor

ok, but we didn't have a corresponding issue ticket for that, right?

Contributor

Hiradur commented May 5, 2016

ok, but we didn't have a corresponding issue ticket for that, right?

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr May 5, 2016

Member

@Hiradur No ticket, just an issue 😄 IIRC it was reported in the Gitter chat.
#863

Member

only-a-ptr commented May 5, 2016

@Hiradur No ticket, just an issue 😄 IIRC it was reported in the Gitter chat.
#863

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur May 5, 2016

Contributor

ok, I got it now, I was confusing by #844

Contributor

Hiradur commented May 5, 2016

ok, I got it now, I was confusing by #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment