New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Update prop animation outside of physics core #904

Merged
merged 9 commits into from Sep 2, 2016

Conversation

Projects
None yet
4 participants
@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq May 13, 2016

Contributor

This somehow changes the rotational speed of props.

Steps to reproduce:

* Spawn a Thomas Saf-T-Liner HDX
* Enter first person view (cinecam)
* Press F6

Then watch the ventilator.

Edit: Fixed with: 1319a04

Contributor

ulteq commented May 13, 2016

This somehow changes the rotational speed of props.

Steps to reproduce:

* Spawn a Thomas Saf-T-Liner HDX
* Enter first person view (cinecam)
* Press F6

Then watch the ventilator.

Edit: Fixed with: 1319a04

mikadou added some commits May 13, 2016

[Refactor] Improve readability of props animation constraints handling
* pack constraints into dedicated struct
* use descriptive flags to indicate if a constraint is effective
* remove obfuscating animOpt4 member
[Refactor] Remove default animation constraints from simulation
Default constraints are now defined during spawning, if needed.

*Caution*: This might cause incompatibilities when a vehicle relies on
default limits for rotation and offset within a single animation
(assumed to be very unlikely)
@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Jun 1, 2016

Collaborator

With this PR, the fans speed in hdx varies as the fps change.

While driving at 60 fps is good fast, but at 30 or lower is noticeable slow.

(sorry for bad english)

Collaborator

tritonas00 commented Jun 1, 2016

With this PR, the fans speed in hdx varies as the fps change.

While driving at 60 fps is good fast, but at 30 or lower is noticeable slow.

(sorry for bad english)

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Jun 4, 2016

Collaborator

Please ignore my previous message, it happens without this PR also.

Collaborator

tritonas00 commented Jun 4, 2016

Please ignore my previous message, it happens without this PR also.

@only-a-ptr only-a-ptr added this to the 0.4.7.0 milestone Aug 30, 2016

@only-a-ptr only-a-ptr self-assigned this Aug 30, 2016

@only-a-ptr only-a-ptr merged commit 77675b7 into RigsOfRods:master Sep 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment