Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Bugfix] Fixes 'nullptr' dereferencing #931
May 17, 2016
1 check passed
Sorry, but this is an [uglyhack]. I hate this "blind nullptr checking" - it says "Devs don't know what's going on in their code, so they step carefully".
Like I commented in the issue, the problem is one part of the code deletes the dashboard while other part tries to update it. The only right solution is to add a mechanism to queue the dashboard destruction and make the responsible code delete it.
Of course, I'm glad you're fixing actual bugs, but there's a pattern - RoR does awfully lot of stuff out of sync, and we can't monkey-patch it forever.