New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes 'nullptr' dereferencing #931

Merged
merged 1 commit into from May 17, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented May 17, 2016

Fixes: #905

@ulteq ulteq merged commit 0b1ce2e into RigsOfRods:master May 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:segfault-fixes branch May 17, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr May 18, 2016

Member

Sorry, but this is an [uglyhack]. I hate this "blind nullptr checking" - it says "Devs don't know what's going on in their code, so they step carefully".

Like I commented in the issue, the problem is one part of the code deletes the dashboard while other part tries to update it. The only right solution is to add a mechanism to queue the dashboard destruction and make the responsible code delete it.

Of course, I'm glad you're fixing actual bugs, but there's a pattern - RoR does awfully lot of stuff out of sync, and we can't monkey-patch it forever.

Member

only-a-ptr commented May 18, 2016

Sorry, but this is an [uglyhack]. I hate this "blind nullptr checking" - it says "Devs don't know what's going on in their code, so they step carefully".

Like I commented in the issue, the problem is one part of the code deletes the dashboard while other part tries to update it. The only right solution is to add a mechanism to queue the dashboard destruction and make the responsible code delete it.

Of course, I'm glad you're fixing actual bugs, but there's a pattern - RoR does awfully lot of stuff out of sync, and we can't monkey-patch it forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment