New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Untangled the 'Streamable' packet queue manipulation #935

Merged
merged 4 commits into from May 18, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented May 17, 2016

No description provided.

@ulteq ulteq changed the title from Cleanup] Untangled the 'Streamable' packet queue manipulation to [Cleanup] Untangled the 'Streamable' packet queue manipulation May 17, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr May 18, 2016

Member

Kudos for fightting the Stream* monster. Cleanups are good. But I have some notes.

EDIT: OK, I had some rants 😄

Member

only-a-ptr commented May 18, 2016

Kudos for fightting the Stream* monster. Cleanups are good. But I have some notes.

EDIT: OK, I had some rants 😄

@@ -39,6 +39,8 @@ Streamable::~Streamable()
void Streamable::addPacket(int type, unsigned int len, char* content)
{
#ifdef USE_SOCKETW
std::lock_guard<std::mutex> lock(m_send_work_mutex);

This comment has been minimized.

@only-a-ptr

only-a-ptr May 18, 2016

Member

Ahem.... commit says [Cleanup]
Adding a new mutex is totally not a cleanup

@only-a-ptr

only-a-ptr May 18, 2016

Member

Ahem.... commit says [Cleanup]
Adding a new mutex is totally not a cleanup

This comment has been minimized.

@ulteq

ulteq May 18, 2016

Contributor

Better than having a race on the packet queue?

@ulteq

ulteq May 18, 2016

Contributor

Better than having a race on the packet queue?

This comment has been minimized.

@only-a-ptr

only-a-ptr May 18, 2016

Member

Better than having a race on the packet queue?

Absolutely, but that's a honorable [bugfix], not a [cleanup].

@only-a-ptr

only-a-ptr May 18, 2016

Member

Better than having a race on the packet queue?

Absolutely, but that's a honorable [bugfix], not a [cleanup].

@ulteq ulteq merged commit c2471b8 into RigsOfRods:master May 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:packet-queue-locking-cleanup branch May 18, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr May 19, 2016

Member

Now it's perfect.
Keep up the good work.

Member

only-a-ptr commented May 19, 2016

Now it's perfect.
Keep up the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment