Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] DDragon examples do not match DDragon schema #370

Closed
bangingheads opened this issue Sep 20, 2020 · 1 comment
Closed

[DOCS] DDragon examples do not match DDragon schema #370

bangingheads opened this issue Sep 20, 2020 · 1 comment

Comments

@bangingheads
Copy link

Champion Passive Assets

The docs have a "sanitizedDescription" key where this does not exist in DDragon.

Champion Ability Assets

The docs have in order "name","key","description","sanitizedDescription","image"
DDragon has "id","name","description","tooltip"..."image"

"key" and "sanitizedDescription" are not keys for a spell. "key" would be "id" and sanitizedDescription does not exist.

@tisbells tisbells added pending: acknowledged We're aware of this issue and are investigating. topic: documentation labels Aug 1, 2023
@lucasMesquitaBorges
Copy link

Docs updated to reflect the data dragon fields. Thanks for reporting this.

@lucasMesquitaBorges lucasMesquitaBorges added closed: resolved topic: ddrag lol League of Legends Data Dragon and removed pending: acknowledged We're aware of this issue and are investigating. labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants