/developer-relations

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: league-v4.LeaguePositionDTO.position missing description #78

Closed
MingweiSamuel opened this Issue Feb 2, 2019 · 1 comment

Comments

Assignees
No one assigned
Labels
closed: resolved topic: documentation type: inconsistency
Projects
None yet
Milestone
No milestone
2 participants
@MingweiSamuel @RiotTuxedo
@MingweiSamuel
Copy link

MingweiSamuel commented Feb 2, 2019

super tiny issue

for LeaguePositionDTO

https://developer.riotgames.com/api-methods/#league-v4/GET_getAllLeaguePositionsForSummoner
shows

position string (Legal values: APEX, TOP, JUNGLE, MIDDLE, BOTTOM, UTILITY, NONE)

but the description is missing for https://developer.riotgames.com/api-methods/#league-v4/GET_getPositionalLeagueEntries

position string

Just needs to have the description copied over, many thanks 💌

@MingweiSamuel MingweiSamuel changed the title league-v4.LeaguePositionDTO.position missing description docs: league-v4.LeaguePositionDTO.position missing description Feb 2, 2019

@RiotTuxedo RiotTuxedo added topic: documentation closed: resolved type: inconsistency labels Feb 12, 2019

@RiotTuxedo

This comment has been minimized.

Sign in to view
Copy link

RiotTuxedo commented Feb 12, 2019

Should be updated now.

@RiotTuxedo RiotTuxedo closed this Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment