New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: lol-status-v3.Translation incorrect "updated_at" -> "heading" field in documentation #79

Open
MingweiSamuel opened this Issue Feb 2, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@MingweiSamuel
Copy link

MingweiSamuel commented Feb 2, 2019

https://developer.riotgames.com/api-methods/#lol-status-v3/GET_getShardData

example call: https://euw1.api.riotgames.com/lol/status/v3/shard-data

For the Translation DTO, docs have:

NAME DATA TYPE DESCRIPTION
locale string  
content string  
updated_at string

But it should be

NAME DATA TYPE DESCRIPTION
locale string  
content string  
heading string

@MingweiSamuel MingweiSamuel changed the title docs: lol-status-v3.Translation incorrect field in documentation docs: lol-status-v3.Translation incorrect "updated_at" -> "heading" field in documentation Feb 2, 2019

@Querijn

This comment has been minimized.

Copy link

Querijn commented Feb 2, 2019

Result of that call: https://irule.at/riot/api/requests/12.json

This breaks my application due to the fact it generates structs from Mingwei's Swagger, which is based on the documentation. There is a manual patch in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment