Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Include "info" diagnostic messages (for clang executable mode) #104

merged 1 commit into from Dec 2, 2011


None yet
2 participants

exclipy commented Dec 2, 2011

I previously submitted a patch to add the "info" diagnostics when using libclang. This patch does the same thing for non-libclang mode.

Here's some code to try this patch on:

template <class T> class A {
    typedef T::type x;

A<int> a;

With this fix, the diagnostic results are:

test.cpp|2 col 13 error| missing 'typename' prior to dependent type name 'T::type'
test.cpp|2 col 13 error| type 'int' cannot be used prior to '::' because it has no members
test.cpp|5 col 8 info| in instantiation of template class 'A<int>' requested here

(Before this patch, the last entry doesn't exist).

@Silex Silex added a commit that referenced this pull request Dec 2, 2011

@Silex Silex Merge pull request #104 from exclipy/info_diagnostic
Include "note" diagnostic messages (for clang executable mode)

@Silex Silex merged commit 8fa8cd5 into Rip-Rip:master Dec 2, 2011


Silex commented Dec 2, 2011

I don't see much that can go wrong so I applied it blindly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment