Skip to content

Correctly execute the command passed to cc_args.py #131

Merged
merged 1 commit into from Mar 18, 2012

3 participants

@ianliu
ianliu commented Mar 18, 2012

The original command line passed to cc_args.py program was losing shell
escaping sequences. For instance, if one would execute the following
command

$ cc_args.py gcc -DVERSION=\"0.1.0\" ...

the command would first be unescaped by the shell and then cc_args.py
would execute

$ gcc -DVERSION="0.1.0" ...

which is incorrect. With this patch, cc_args.py uses Python's subprocess
module, which executes correctly.

@ianliu ianliu Correctly execute the command passed to cc_args.py
The original command line passed to cc_args.py program was losing shell
escaping sequences. For instance, if one would execute the following
command

 $ cc_args.py gcc -DVERSION=\"0.1.0\" ...

the command would first be unescaped by the shell and then cc_args.py
would execute

 $ gcc -DVERSION="0.1.0" ...

which is incorrect.
0b6b4c0
@xaizek xaizek merged commit dae9c12 into Rip-Rip:master Mar 18, 2012
@xaizek
Collaborator
xaizek commented Mar 18, 2012

Thanks!

@jonpasski

Ah, my bad. I'm using Vundle and it's pulling from https://github.com/vim-scripts/clang-complete, not here. Changing remote origin. Sorry about the dup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.