Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for batch. #70

Merged
merged 1 commit into from Jan 28, 2019
Merged

Conversation

moritzuehling
Copy link
Contributor

@moritzuehling moritzuehling commented Nov 29, 2018

The batch-API is not included in the typescript-definitions. This pull-request should add it.

The generics are mostly there to allow automatic type inference of the return value, and can be left out when writing:

image

If the compiler can't infer it, it'll default to any.

@solkimicreb
Copy link
Member

Thanks! I will merge and release soon.

@moritzuehling
Copy link
Contributor Author

Any update on this?

@solkimicreb solkimicreb merged commit 85a92bb into RisingStack:master Jan 28, 2019
@solkimicreb
Copy link
Member

I will release it this week together with some other changes. Sorry for the slow merge and big thanks for the help!

@moritzuehling
Copy link
Contributor Author

Don't worry - I had just the same project in a new project and was wondering if it had been fixed yet, so I looked here again.
I simply re-used my workaround from back then, and hopefully remember to remove it after the release :)

@solkimicreb
Copy link
Member

This is included in the v6.1.0 release (changelog). Thanks again for the help 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants