New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS Mask Results Order For Directional #235

Closed
philipbaileynar opened this Issue Apr 17, 2018 · 3 comments

Comments

3 participants
@philipbaileynar
Copy link
Contributor

philipbaileynar commented Apr 17, 2018

The Problem

When viewing BS results the classes should be in the drop down in descending order of direction field in the mask.

@MattReimer MattReimer added this to the Next Version - Tackle After GeoTERM Workshop milestone Apr 18, 2018

@philipbaileynar philipbaileynar moved this from Temp to Medium in Post Workshop Breakdown May 16, 2018

@joewheaton

This comment has been minimized.

Copy link
Contributor

joewheaton commented May 29, 2018

This is @jb10016 top 4 priority (4 of 4).

@philipbaileynar

This comment has been minimized.

Copy link
Contributor

philipbaileynar commented Aug 2, 2018

This was actually fairly nuanced to fix without breaking non-directional masks. In the screenshot below, notice how the dropdown of classes in the BS results is in ascending order of the Direction field in the ShapeFile attribute. Before this fix, items were listed in the BS results in the order of the features in the ShapeFile (LiDAR, Total Station, total station etc).

2018-08-02_095034

@philipbaileynar

This comment has been minimized.

Copy link
Contributor

philipbaileynar commented Aug 2, 2018

And here's a quick video showing the implemenation (also applies to #236)

https://youtu.be/jDB_FmVbf7A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment