New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new 'Options' for DoD symbology range default and change default. #286

Closed
joewheaton opened this Issue May 29, 2018 · 4 comments

Comments

4 participants
@joewheaton
Copy link
Contributor

joewheaton commented May 29, 2018

In the %user\AppData\Roaming\GCD\LayerFiles folder we have a DoD_Classed_1m.lyr and DoD_Classed_2.5m.lyr symbology for DoDs. As described in #285, the default for DoDs is to stretch symbology symmetrically about zero according the max DoD that occurs in a raster. This is really annoying as many DoDs have erroneously high maxes. We often import the symbology from here manually to the 2.5m one.

My request is to add to the Options→Symbology tab an option to select the default symoblogy for DoDs from:

  • Based on max DoD value in raster (current default)
  • Based on +/- 2.5 m range (new default)
  • Basedon +/- 1 m range
@joewheaton

This comment has been minimized.

Copy link
Contributor

joewheaton commented May 29, 2018

When @jb10016 and I discussed all the tickets, the one idea we didn't think got captured from Scotland that was discussed was #285. That seems like a lot to ask and we're assuming its too much work. As such we've shelved that issue (please move to correct amount of work).

However, @philipbaileynar we're assuming that the above would be pretty small and easy to update because it would not require any new saving of data to the project *.gcd file? Maybe I'm wrong. Under that assumption, we slipped it in under current if time.

@philipbaileynar

This comment has been minimized.

Copy link
Contributor

philipbaileynar commented Aug 2, 2018

Here's a quick demonstrating the implementation that I ended up with

https://youtu.be/DxrO6t1DqE0

philipbaileynar added a commit that referenced this issue Aug 2, 2018

@joewheaton

This comment has been minimized.

Copy link
Contributor

joewheaton commented Aug 2, 2018

Thanks @philipbaileynar. I think that works for now, but we need to change in the Settings to add a tool tip for what this is. We also need a more descriptive label than Manual DoD symbology range. Maybe something like Manually specify DoD symbology range? +/- then show the box you have, then list the vertical units (e.g. m) of the project. I suppose a help page on this will help and that falls in my court. Please also adjust the default to +/- 2.5 m in the toolbox.

I'd still rather see this instead of as a checkbox a radio button choice in its own DoD Symbology Range group control with choices:

  • Based on +/- 1 m range (new default)
  • Based on max DoD value in raster (current default)
  • Based on custom user specified +/- ______ m range (use default of 2.5 m in there)
@jb10016

This comment has been minimized.

Copy link
Collaborator

jb10016 commented Aug 21, 2018

@joewheaton @philipbaileynar I like this - it's neat a simple and provides a ready way for users to tailor the graphics effectively. A couple of related thoughts:

a) does this selection update the set of auto-generated graphics?
b) happy to go with Joe's suggestions based on radio buttons (largely to constrain choices) but I do wonder whether you need somewhere (i.e., a tool tip or hard text) to identify the limits of 0.1 - 1000

philipbaileynar added a commit that referenced this issue Aug 21, 2018

philipbaileynar added a commit that referenced this issue Aug 22, 2018

@MattReimer MattReimer added this to the 7.1.x Next Release milestone Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment