New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pctcompile - result property is not set #320

Closed
clement-brodu opened this Issue Sep 17, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@clement-brodu

clement-brodu commented Sep 17, 2018

Subject of the issue

the result property for pct compile is not correct at the end of task

Your environment

  • Windows 7
  • OpenEdge 11.7.2
  • Ant 1.10.5
  • PCT 209

Actual behaviour

I set failOnError to false.
When compilation failed, the result property is "0" instead of "10"

Expected behaviour

Get the task result.

Steps to reproduce

Failed a compilation.

The problem

I think I found the problem here (line 99) :
https://github.com/Riverside-Software/pct/blob/master/src/progress/pct/pctCompile.p

You should probably delete the AND failOnErr because it's redundant with the code in "pctrun.java"

@gquerret

This comment has been minimized.

Show comment
Hide comment
@gquerret

gquerret Sep 18, 2018

Contributor

Reproduced, fix will be included in next version, thanks for feedback !

Contributor

gquerret commented Sep 18, 2018

Reproduced, fix will be included in next version, thanks for feedback !

gquerret added a commit that referenced this issue Sep 18, 2018

@gquerret

This comment has been minimized.

Show comment
Hide comment
@gquerret

gquerret Sep 18, 2018

Contributor

Merged in master

Contributor

gquerret commented Sep 18, 2018

Merged in master

@gquerret gquerret closed this Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment