New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ENUM - Dropped anything below 11.6 #189

Merged
merged 10 commits into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@gquerret
Contributor

gquerret commented Nov 24, 2016

No description provided.

+ (isFinal ? " FINAL " : "") + returnType + " " + methodName + "(";
boolean first = true;
for (Parameter p : parameters) {
s += (first ? "" : ", ") + p.toString();

This comment has been minimized.

@jakejustus

jakejustus Feb 21, 2017

Collaborator

MINOR Use a StringBuilder instead. rule

@jakejustus

jakejustus Feb 21, 2017

Collaborator

MINOR Use a StringBuilder instead. rule

@XmlElement(name = "function")
public List<Function> functions = new ArrayList<>();
public void toXML(File out) throws JAXBException, IOException {

This comment has been minimized.

@jakejustus

jakejustus Mar 13, 2017

Collaborator

MAJOR Refactor this method to throw at most one checked exception instead of: javax.xml.bind.JAXBException, java.io.IOException rule

@jakejustus

jakejustus Mar 13, 2017

Collaborator

MAJOR Refactor this method to throw at most one checked exception instead of: javax.xml.bind.JAXBException, java.io.IOException rule

@XmlElement(name = "dataset")
public List<Dataset> dss = new ArrayList<>();
public void classToXML(File out) throws JAXBException, IOException {

This comment has been minimized.

@jakejustus

jakejustus Apr 16, 2017

Collaborator

MAJOR Refactor this method to throw at most one checked exception instead of: javax.xml.bind.JAXBException, java.io.IOException rule

@jakejustus

jakejustus Apr 16, 2017

Collaborator

MAJOR Refactor this method to throw at most one checked exception instead of: javax.xml.bind.JAXBException, java.io.IOException rule

@jakejustus

This comment has been minimized.

Show comment
Hide comment
@jakejustus

jakejustus Apr 16, 2017

Collaborator

SonarQube analysis reported 3 issues

  • MAJOR 2 major
  • MINOR 1 minor

Watch the comments in this conversation to review them.

Collaborator

jakejustus commented Apr 16, 2017

SonarQube analysis reported 3 issues

  • MAJOR 2 major
  • MINOR 1 minor

Watch the comments in this conversation to review them.

@gquerret gquerret merged commit 2322fae into master Apr 27, 2017

2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
sonarqube SonarQube reported 3 issues, no criticals or blockers

@gquerret gquerret deleted the EnumClassDoc branch Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment