New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-pass compilation when using 11.7 COMPILER options #229

Merged
merged 3 commits into from Apr 18, 2017

Conversation

Projects
None yet
2 participants
@gquerret
Contributor

gquerret commented Apr 18, 2017

No description provided.

COMPILE VALUE(IF lRelative THEN ipInFile ELSE ipInDir + '/':U + ipInFile) SAVE=FALSE OPTIONS cOpts NO-ERROR.
IF COMPILER:ERROR THEN DO i = 1 TO COMPILER:NUM-MESSAGES:
/* Messages 14786, 14789, 18494 are the only relevant ones */
IF (COMPILER:GET-NUMBER(i) EQ 14786) OR (COMPILER:GET-NUMBER(i) EQ 14789) OR (COMPILER:GET-NUMBER(i) EQ 18494) THEN DO:

This comment has been minimized.

@jakejustus

jakejustus Apr 18, 2017

Collaborator

MINOR Line is 125 characters long, exceeding maximum value of 120 rule

@jakejustus

jakejustus Apr 18, 2017

Collaborator

MINOR Line is 125 characters long, exceeding maximum value of 120 rule

@@ -498,6 +518,9 @@ PROCEDURE compileXref.
END.
END.
END.
FOR EACH ttWarnings:

This comment has been minimized.

@jakejustus

jakejustus Apr 18, 2017

Collaborator

MAJOR WHOLE-INDEX search on temp-table ttWarnings - Index used : default rule

@jakejustus

jakejustus Apr 18, 2017

Collaborator

MAJOR WHOLE-INDEX search on temp-table ttWarnings - Index used : default rule

@@ -498,6 +518,9 @@ PROCEDURE compileXref.
END.
END.
END.
FOR EACH ttWarnings:
PUT STREAM sWarnings UNFORMATTED SUBSTITUTE("[&1] [&3] &2", ttWarnings.rowNum, ttWarnings.msg, ttWarnings.fileName) SKIP.

This comment has been minimized.

@jakejustus

jakejustus Apr 18, 2017

Collaborator

MINOR Line is 129 characters long, exceeding maximum value of 120 rule

@jakejustus

jakejustus Apr 18, 2017

Collaborator

MINOR Line is 129 characters long, exceeding maximum value of 120 rule

gquerret added some commits Apr 18, 2017

@jakejustus

This comment has been minimized.

Show comment
Hide comment
@jakejustus

jakejustus Apr 18, 2017

Collaborator

SonarQube analysis reported 13 issues

  • CRITICAL 10 critical
  • MAJOR 1 major
  • MINOR 2 minor

Watch the comments in this conversation to review them.

10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL compile.p#L34: Cannot reference "INITIAL" as "INIT" due to the "require-full-keywords" compiler option. (18494) rule
  2. CRITICAL compile.p#L208: Cannot reference "INTEGER" as "INT" due to the "require-full-keywords" compiler option. (18494) rule
  3. CRITICAL compile.p#L433: Cannot reference "TEXT-SEG-GROWTH" as "TEXT-SEG-GROW" due to the "require-full-keywords" compiler option. (18494) rule
  4. CRITICAL compile.p#L448: Cannot reference "TEXT-SEG-GROWTH" as "TEXT-SEG-GROW" due to the "require-full-keywords" compiler option. (18494) rule
  5. CRITICAL compile.p#L609: You must qualify the field "Reference-Type" with the table name "Reference" due to the "require-field-qualifiers" compiler option. (14789) rule
  6. CRITICAL compile.p#L639: You must qualify the field "ttIncName" with the table name "ttXrefInc" due to the "require-field-qualifiers" compiler option. (14789) rule
  7. CRITICAL compile.p#L646: You must qualify the field "ttTblName" with the table name "ttXrefCRC" due to the "require-field-qualifiers" compiler option. (14789) rule
  8. CRITICAL compile.p#L708: You must qualify the field "xRefType" with the table name "ttXref" due to the "require-field-qualifiers" compiler option. (14789) rule
  9. CRITICAL compile.p#L726: You must qualify the field "xRefType" with the table name "ttXref" due to the "require-field-qualifiers" compiler option. (14789) rule
  10. CRITICAL compile.p#L746: You must qualify the field "xRefType" with the table name "ttXref" due to the "require-field-qualifiers" compiler option. (14789) rule
Collaborator

jakejustus commented Apr 18, 2017

SonarQube analysis reported 13 issues

  • CRITICAL 10 critical
  • MAJOR 1 major
  • MINOR 2 minor

Watch the comments in this conversation to review them.

10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL compile.p#L34: Cannot reference "INITIAL" as "INIT" due to the "require-full-keywords" compiler option. (18494) rule
  2. CRITICAL compile.p#L208: Cannot reference "INTEGER" as "INT" due to the "require-full-keywords" compiler option. (18494) rule
  3. CRITICAL compile.p#L433: Cannot reference "TEXT-SEG-GROWTH" as "TEXT-SEG-GROW" due to the "require-full-keywords" compiler option. (18494) rule
  4. CRITICAL compile.p#L448: Cannot reference "TEXT-SEG-GROWTH" as "TEXT-SEG-GROW" due to the "require-full-keywords" compiler option. (18494) rule
  5. CRITICAL compile.p#L609: You must qualify the field "Reference-Type" with the table name "Reference" due to the "require-field-qualifiers" compiler option. (14789) rule
  6. CRITICAL compile.p#L639: You must qualify the field "ttIncName" with the table name "ttXrefInc" due to the "require-field-qualifiers" compiler option. (14789) rule
  7. CRITICAL compile.p#L646: You must qualify the field "ttTblName" with the table name "ttXrefCRC" due to the "require-field-qualifiers" compiler option. (14789) rule
  8. CRITICAL compile.p#L708: You must qualify the field "xRefType" with the table name "ttXref" due to the "require-field-qualifiers" compiler option. (14789) rule
  9. CRITICAL compile.p#L726: You must qualify the field "xRefType" with the table name "ttXref" due to the "require-field-qualifiers" compiler option. (14789) rule
  10. CRITICAL compile.p#L746: You must qualify the field "xRefType" with the table name "ttXref" due to the "require-field-qualifiers" compiler option. (14789) rule

@gquerret gquerret merged commit f107c4c into master Apr 18, 2017

0 of 2 checks passed

sonarqube SonarQube reported 13 issues, with 10 critical
continuous-integration/jenkins/pr-merge This commit has test failures
Details

@gquerret gquerret deleted the CompilerOptions branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment