New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-the-fly xcode of init procedure for runtime environments #263

Merged
merged 4 commits into from Sep 13, 2017

Conversation

Projects
None yet
2 participants
@gquerret
Contributor

gquerret commented Sep 1, 2017

No description provided.

gquerret added some commits Aug 31, 2017

@jakejustus

This comment has been minimized.

Show comment
Hide comment
@jakejustus

jakejustus Sep 1, 2017

Collaborator

SonarQube analysis reported 2 issues

  • MAJOR 2 major

Watch the comments in this conversation to review them.

Collaborator

jakejustus commented Sep 1, 2017

SonarQube analysis reported 2 issues

  • MAJOR 2 major

Watch the comments in this conversation to review them.

gquerret added some commits Sep 1, 2017

}
try {
Files.deleteIfExists(file.toPath());
} catch (IOException caught) {

This comment has been minimized.

@jakejustus

jakejustus Sep 1, 2017

Collaborator

MAJOR Either log or rethrow this exception. rule

@jakejustus

jakejustus Sep 1, 2017

Collaborator

MAJOR Either log or rethrow this exception. rule

}
try {
Files.deleteIfExists(directory.toPath());
} catch (IOException caught) {

This comment has been minimized.

@jakejustus

jakejustus Sep 1, 2017

Collaborator

MAJOR Either log or rethrow this exception. rule

@jakejustus

jakejustus Sep 1, 2017

Collaborator

MAJOR Either log or rethrow this exception. rule

@gquerret gquerret merged commit bc2073f into master Sep 13, 2017

2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
sonarqube SonarQube reported 2 issues, no criticals or blockers

@gquerret gquerret deleted the XCodeInit branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment