New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCodeSessionKey attribute #282

Merged
merged 6 commits into from Jan 9, 2018

Conversation

Projects
None yet
2 participants
@gquerret
Contributor

gquerret commented Jan 4, 2018

No description provided.

@jakejustus

This comment has been minimized.

Show comment
Hide comment
@jakejustus

jakejustus Jan 4, 2018

Collaborator

SonarQube analysis reported 2 issues

  • MAJOR 1 major
  • INFO 1 info

Watch the comments in this conversation to review them.

Collaborator

jakejustus commented Jan 4, 2018

SonarQube analysis reported 2 issues

  • MAJOR 1 major
  • INFO 1 info

Watch the comments in this conversation to review them.

@@ -230,9 +230,10 @@ public void setXCode(boolean xcode) {
compAttributes.setXCode(xcode);
}
@Deprecated
@Override
public void setXCodeKey(String xcodeKey) {

This comment has been minimized.

@jakejustus

jakejustus Jan 4, 2018

Collaborator

MAJOR Add the missing @deprecated Javadoc tag. rule
INFO Do not forget to remove this deprecated code someday. rule

@jakejustus

jakejustus Jan 4, 2018

Collaborator

MAJOR Add the missing @deprecated Javadoc tag. rule
INFO Do not forget to remove this deprecated code someday. rule

@gquerret gquerret merged commit 2dec804 into master Jan 9, 2018

2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
sonarqube SonarQube reported 2 issues, no criticals or blockers

@gquerret gquerret deleted the XCodeSessionKey branch Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment