From 91d84b48e620c997e34b64b805bbffa3e37c8545 Mon Sep 17 00:00:00 2001 From: "Carol (Nichols || Goulding)" Date: Mon, 16 Oct 2023 11:56:01 -0400 Subject: [PATCH 1/4] Add a CI job to check the minimal version constraints of direct dependencies See for more details --- .github/workflows/rust.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index e116ed6..e68b53a 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -70,3 +70,7 @@ jobs: - name: Benchmark if: matrix.rust == 'nightly' run: cargo +${{ matrix.rust }} bench + + - name: Minimal versions + if: matrix.rust == 'nightly' + run: cargo +${{ matrix.rust }} -Zdirect-minimal-versions build From 435ae214ad9010601159fb711e1180084db710f6 Mon Sep 17 00:00:00 2001 From: "Carol (Nichols || Goulding)" Date: Mon, 16 Oct 2023 12:01:02 -0400 Subject: [PATCH 2/4] Update minimal version of byteorder to be compatible with roaring --- croaring/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/croaring/Cargo.toml b/croaring/Cargo.toml index 90686f2..ed4b49e 100644 --- a/croaring/Cargo.toml +++ b/croaring/Cargo.toml @@ -23,7 +23,7 @@ criterion = { version = "0.5", features = ["html_reports"] } [dependencies] ffi = { package = "croaring-sys", path = "../croaring-sys", version = "1.0.0" } -byteorder = "1" +byteorder = "1.4.3" [[bench]] name = "benches" From 5c374d35bc67226f03290121cb42e2040927f3b8 Mon Sep 17 00:00:00 2001 From: "Carol (Nichols || Goulding)" Date: Mon, 16 Oct 2023 12:07:10 -0400 Subject: [PATCH 3/4] Update minimal version of croaring-sys that croaring needs --- croaring/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/croaring/Cargo.toml b/croaring/Cargo.toml index ed4b49e..3eea104 100644 --- a/croaring/Cargo.toml +++ b/croaring/Cargo.toml @@ -22,7 +22,7 @@ roaring = "0.10" criterion = { version = "0.5", features = ["html_reports"] } [dependencies] -ffi = { package = "croaring-sys", path = "../croaring-sys", version = "1.0.0" } +ffi = { package = "croaring-sys", path = "../croaring-sys", version = "1.1.0" } byteorder = "1.4.3" [[bench]] From 8c855f55cff92ccf4aeb86b04ba7e8b1976e8ee8 Mon Sep 17 00:00:00 2001 From: "Carol (Nichols || Goulding)" Date: Wed, 18 Oct 2023 09:53:39 -0400 Subject: [PATCH 4/4] Test with minimal versions rather than only building --- .github/workflows/rust.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index e68b53a..68c4804 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -73,4 +73,4 @@ jobs: - name: Minimal versions if: matrix.rust == 'nightly' - run: cargo +${{ matrix.rust }} -Zdirect-minimal-versions build + run: cargo +${{ matrix.rust }} -Zdirect-minimal-versions test