Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locateIdentifiersByType to correctly aggregate source #166

Merged
merged 1 commit into from Feb 7, 2016

Conversation

@AydinHassan
Copy link
Contributor

@AydinHassan AydinHassan commented Feb 6, 2016

Hi,

It seems the aggregate source locator was not working as += ignores keys that already exist in left hand array:

The + operator returns the right-hand array appended to the left-hand array; for keys that exist in both arrays, the elements from the left-hand array will be used, and the matching elements from the right-hand array will be ignored.

refs: http://php.net/manual/en/language.operators.array.php

@Ocramius Ocramius added the bug label Feb 7, 2016
@Ocramius Ocramius added this to the 1.1.0 milestone Feb 7, 2016
@Ocramius Ocramius added this to the 1.0.1 milestone Feb 7, 2016
@Ocramius Ocramius removed this from the 1.1.0 milestone Feb 7, 2016
@asgrim
Copy link
Member

@asgrim asgrim commented Feb 7, 2016

LGTM 👍

asgrim added a commit that referenced this issue Feb 7, 2016
Fix locateIdentifiersByType to correctly aggregate source
@asgrim asgrim merged commit d428b55 into Roave:master Feb 7, 2016
2 checks passed
@asgrim
Copy link
Member

@asgrim asgrim commented Feb 7, 2016

Thanks @AydinHassan

@AydinHassan AydinHassan deleted the hotfix/aggregate-source-locator branch Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants