Skip to content

Fix locateIdentifiersByType to correctly aggregate source - #166

Merged
asgrim merged 1 commit into
Roave:masterfrom
AydinHassan:hotfix/aggregate-source-locator
Feb 7, 2016
Merged

Fix locateIdentifiersByType to correctly aggregate source#166
asgrim merged 1 commit into
Roave:masterfrom
AydinHassan:hotfix/aggregate-source-locator

Conversation

@AydinHassan

Copy link
Copy Markdown
Contributor

Hi,

It seems the aggregate source locator was not working as += ignores keys that already exist in left hand array:

The + operator returns the right-hand array appended to the left-hand array; for keys that exist in both arrays, the elements from the left-hand array will be used, and the matching elements from the right-hand array will be ignored.

refs: http://php.net/manual/en/language.operators.array.php

@Ocramius Ocramius added the bug label Feb 7, 2016
@Ocramius Ocramius modified the milestones: 1.1.0, 1.0.1 Feb 7, 2016
@asgrim

asgrim commented Feb 7, 2016

Copy link
Copy Markdown
Member

LGTM 👍

asgrim added a commit that referenced this pull request Feb 7, 2016
Fix locateIdentifiersByType to correctly aggregate source
@asgrim
asgrim merged commit d428b55 into Roave:master Feb 7, 2016
@asgrim

asgrim commented Feb 7, 2016

Copy link
Copy Markdown
Member

Thanks @AydinHassan

@AydinHassan
AydinHassan deleted the hotfix/aggregate-source-locator branch February 19, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants