Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect internal functions that are @deprecated #660

Merged
merged 4 commits into from Jul 9, 2020

Conversation

@ondrejmirtes
Copy link
Contributor

This should probably be done as an enhancement of #603 to be really good. (We don't want to tell people running on PHP 7.1 about a deprecation on 7.4.)

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed, but otherwise patcb looking good! 👍

src/Reflection/ReflectionFunctionAbstract.php Outdated Show resolved Hide resolved
src/Reflection/ReflectionFunctionAbstract.php Outdated Show resolved Hide resolved
@Ocramius Ocramius modified the milestones: 4.6.0, 4.7.0 Jun 11, 2020
@Ocramius Ocramius modified the milestones: 4.7.0, 4.8.0 Jul 6, 2020
@Ocramius Ocramius self-assigned this Jul 9, 2020
@Ocramius Ocramius merged commit 52f6737 into Roave:master Jul 9, 2020
@Ocramius Ocramius changed the title Allow functions to be deprecated Detect internal functions that are @deprecated Jul 9, 2020
@Ocramius
Copy link
Member

Ocramius commented Jul 9, 2020

Thanks @BackEndTea!

@BackEndTea
Copy link
Contributor Author

Thanks @Ocramius, @ondrejmirtes & @jaapio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ReflectionFunctions/ReflectionClasses from internal definitions
4 participants