Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] new: Link to GitHub dependencies instead of using relative paths #38

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

shawntabrizi
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files          33       33           
  Lines        3029     3029           
=======================================
  Hits         2722     2722           
  Misses        307      307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9a5fe...703c11a. Read the comment docs.

@Robbepop
Copy link
Collaborator

Robbepop commented Mar 25, 2019

nice!

could you please prepend the commit with [cli] since it is concerned with the pDSL CLI project, e.g. [cli] new: Link to GitHub dependencies instead of using relative paths
I should have written a contribution guideline finally.

@shawntabrizi shawntabrizi changed the title Update cargo.toml to use Git dependency [cli] new: Link to GitHub dependencies instead of using relative paths Mar 25, 2019
@shawntabrizi
Copy link
Contributor Author

Just the title? Or the commit itself?

@Robbepop
Copy link
Collaborator

Robbepop commented Mar 25, 2019

Just the title? Or the commit itself?

It is about the commit itself. Part of the unwritten commit guidelines.
Btw.: I've uploaded the contribution guidelines. :) You can find them here. Happy for feedback.

@Robbepop Robbepop reopened this Mar 25, 2019
@Robbepop
Copy link
Collaborator

lgtm!

@Robbepop Robbepop merged commit 7228fff into use-ink:master Mar 26, 2019
@shawntabrizi shawntabrizi deleted the shawntabrizi-cli branch March 26, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants