Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force USE_INTRINISCS to be set via source-code #234

Merged
merged 1 commit into from Jul 11, 2015

Conversation

coldtobi
Copy link

One important part of #228 was unfortunatly reverted one commit later :(

The problem is, that without those line USE_INTRINSICS cannot be "unset" via the CMake option; If unset, it will be set by the code, which leads bottom line the option always set and not configurable by CMake on

Please note that USE_INTRINSICS defaults to "defined" (see CMakeLists.txt), so the behaviour is the same unless the user overrides this (and with the lines in the code he cannot override it)

Tobi

RobertBeckebans added a commit that referenced this pull request Jul 11, 2015
Do not force USE_INTRINISCS to be set via source-code
@RobertBeckebans RobertBeckebans merged commit 8a2fd15 into RobertBeckebans:master Jul 11, 2015
@RobertBeckebans
Copy link
Owner

Ah your patch disabled intrinsics with MSVC on Windows. I'll make another commit that fixes CMake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants