Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USE_SYSTEM_RADPIDJSON -- Use the system rapidjson instead of the bundled one #351

Merged
merged 2 commits into from Oct 7, 2018
Merged

USE_SYSTEM_RADPIDJSON -- Use the system rapidjson instead of the bundled one #351

merged 2 commits into from Oct 7, 2018

Conversation

coldtobi
Copy link

  • Add rapidjson.cmake to find the system rapidjson
  • Add USE_SYSTEM_RAPIDJSON (default OFF) to select system library.

@RobertBeckebans
Copy link
Owner

I had to modify rapidjson in order to get it to work at all :(

@coldtobi
Copy link
Author

Robert: Can you expand? What problems did you have with stock rapidjson..
(I was just about to create a PR with latest rapidjson and played-tested it a bit and could not find issues, but maybe I did not look into the right direction)

@coldtobi coldtobi mentioned this pull request Oct 10, 2016
Merged
@RobertBeckebans RobertBeckebans merged commit 822f9be into RobertBeckebans:master Oct 7, 2018
@coldtobi coldtobi deleted the use_system_rapidjson branch March 31, 2020 10:13
stephenap07 pushed a commit to stephenap07/SP-RBDOOM-3-BFG that referenced this pull request Jan 31, 2022
@RobertBeckebans
Merge pull request RobertBeckebans#351 from coldtobi/use_system_rapid…
f10fee0 
…json

USE_SYSTEM_RADPIDJSON -- Use the system rapidjson instead of the bundled one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coldtobi @RobertBeckebans