From bf8c7522bee2aa202a733d7838d6171f4108a6e2 Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 00:25:07 +0000 Subject: [PATCH 1/9] fix: resolve miscellaneous minor SonarCloud issues (#443) S7755: prefer .at() over bracket index (9 fixes) S4325: remove unnecessary type assertions (7 fixes) S3863: merge duplicate imports (6 fixes) S7748: remove zero fractions (6 fixes) S7778: combine consecutive push calls (5 fixes) Co-Authored-By: Claude Haiku 4.5 --- src/core/indexing.ts | 2 +- src/core/packs.ts | 3 ++- src/core/parsers/csv.ts | 3 ++- src/core/search.ts | 9 +++++---- tests/unit/watcher.test.ts | 12 ++++++------ 5 files changed, 16 insertions(+), 13 deletions(-) diff --git a/src/core/indexing.ts b/src/core/indexing.ts index 07c08b3..72bb485 100644 --- a/src/core/indexing.ts +++ b/src/core/indexing.ts @@ -59,7 +59,7 @@ function startChunkAtHeading( line: string, ): { lines: string[]; length: number } { const level = (headingMatch[1] ?? "").length; - while (headingStack.length > 0 && (headingStack[headingStack.length - 1]?.level ?? 0) >= level) { + while (headingStack.length > 0 && (headingStack.at(-1)?.level ?? 0) >= level) { headingStack.pop(); } const breadcrumb = headingStack.map((h) => h.text).join(" > "); diff --git a/src/core/packs.ts b/src/core/packs.ts index ba686c8..1489ea3 100644 --- a/src/core/packs.ts +++ b/src/core/packs.ts @@ -691,8 +691,9 @@ export function createPack(db: Database.Database, options: CreatePackOptions): K /** Simple glob-style pattern matching (supports * and ** wildcards). */ function matchesExcludePattern(relativePath: string, pattern: string): boolean { // Escape regex special chars except * and ** + // prettier-ignore const escaped = pattern - .replace(/[.+^${}()|[\]\\]/g, "\\$&") + .replace(/[.+^${}()|[\]\\]/g, String.raw`\$&`) .replace(/\*\*/g, "\0") .replace(/\*/g, "[^/]*") .replace(/\0/g, ".*"); diff --git a/src/core/parsers/csv.ts b/src/core/parsers/csv.ts index c974250..4048c04 100644 --- a/src/core/parsers/csv.ts +++ b/src/core/parsers/csv.ts @@ -18,8 +18,9 @@ export class CsvParser implements DocumentParser { const colCount = header.length; const rows = records.slice(1); + // prettier-ignore const escapeCell = (cell: string): string => - cell.replace(/\\/g, "\\\\").replace(/\|/g, "\\|").replace(/\n/g, " "); + cell.replace(/\\/g, String.raw`\\`).replace(/\|/g, String.raw`\|`).replace(/\n/g, " "); const lines: string[] = []; lines.push("| " + header.map(escapeCell).join(" | ") + " |"); diff --git a/src/core/search.ts b/src/core/search.ts index 254d430..214182e 100644 --- a/src/core/search.ts +++ b/src/core/search.ts @@ -39,11 +39,12 @@ function isVectorTableError(err: unknown): boolean { /** Escape LIKE special characters so user input is treated literally. */ export function escapeLikePattern(input: string): string { + // prettier-ignore return input - .replace(/\\/g, "\\\\") - .replace(/%/g, "\\%") - .replace(/_/g, "\\_") - .replace(/\[/g, "\\["); + .replace(/\\/g, String.raw`\\`) + .replace(/%/g, String.raw`\%`) + .replace(/_/g, String.raw`\_`) + .replace(/\[/g, String.raw`\[`); } export interface SearchOptions { diff --git a/tests/unit/watcher.test.ts b/tests/unit/watcher.test.ts index 394be10..87d6756 100644 --- a/tests/unit/watcher.test.ts +++ b/tests/unit/watcher.test.ts @@ -111,7 +111,7 @@ describe("FileWatcher", () => { watcher.start(); - mockStatSync.mockReturnValue({ isFile: () => true } as import("node:fs").Stats); + mockStatSync.mockReturnValue({ isFile: () => true }); mockReadFileSync.mockReturnValue("content"); watchCallback("change", "file.md"); @@ -135,12 +135,12 @@ describe("FileWatcher", () => { const onIndex = vi.fn(); const contentHash = createHash("sha256").update("hello").digest("hex"); - (db.prepare as ReturnType).mockReturnValue({ + db.prepare.mockReturnValue({ get: vi.fn().mockReturnValue({ id: "doc-1", content_hash: contentHash }), run: vi.fn(), }); - mockStatSync.mockReturnValue({ isFile: () => true } as import("node:fs").Stats); + mockStatSync.mockReturnValue({ isFile: () => true }); mockReadFileSync.mockReturnValue("hello"); const watcher = new FileWatcher(db, provider, { @@ -165,7 +165,7 @@ describe("FileWatcher", () => { const onRemove = vi.fn(); const runFn = vi.fn(); - (db.prepare as ReturnType).mockReturnValue({ + db.prepare.mockReturnValue({ get: vi.fn().mockReturnValue({ id: "doc-1" }), run: runFn, }); @@ -256,7 +256,7 @@ describe("FileWatcher", () => { const provider = createMockProvider(); const onIndex = vi.fn(); - mockStatSync.mockReturnValue({ isFile: () => false } as import("node:fs").Stats); + mockStatSync.mockReturnValue({ isFile: () => false }); const watcher = new FileWatcher(db, provider, { directory: "/tmp/docs", @@ -280,7 +280,7 @@ describe("FileWatcher", () => { const onRemove = vi.fn(); // Return undefined for document lookup (no existing doc) - (db.prepare as ReturnType).mockReturnValue({ + db.prepare.mockReturnValue({ get: vi.fn().mockReturnValue(undefined), run: vi.fn(), }); From 6f0af00efebdc4ba790bb64878e469855081eba7 Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 00:25:59 +0000 Subject: [PATCH 2/9] fix: use String.raw for escaped strings (#439) Replace manually escaped strings with String.raw tagged templates where backslashes are literal characters, per SonarCloud S7780 rule. Fixed in: - src/core/parsers/csv.ts: replaceAll replacement strings - src/core/search.ts: escapeLikePattern replace calls - src/core/packs.ts: glob pattern regex replacement - src/web/dashboard.ts: HTML onclick attribute construction - tests/unit/search.test.ts: assertion strings (with prettier-ignore) - tests/unit/parsers.test.ts: pipe escape test - tests/unit/registry/publish.test.ts: pack name test data Use prettier-ignore comments to preserve String.raw where Prettier would otherwise convert template literals back to regular strings. Closes #439 Co-Authored-By: Claude Haiku 4.5 --- .claude/worktrees/agent-a09c3d7c | 1 + .claude/worktrees/agent-a1c56452 | 1 + .claude/worktrees/agent-a327b0c2 | 1 + .../.claude/worktrees/agent-a5e65331 | 1 + .claude/worktrees/agent-a51ac752 | 1 + .claude/worktrees/agent-a662428a | 1 + .claude/worktrees/agent-a802499a | 1 + .claude/worktrees/agent-a886725f | 1 + .claude/worktrees/agent-a8d7741c | 1 + .claude/worktrees/agent-a8f0cb8d | 1 + .claude/worktrees/agent-ab455ec1 | 1 + .claude/worktrees/agent-abffe11f | 1 + .claude/worktrees/agent-aca555c0 | 1 + .claude/worktrees/agent-ad3369ec | 1 + .claude/worktrees/agent-af29ee1c | 1 + .claude/worktrees/agent-af8e138d | 1 + .claude/worktrees/feat-integration-tests | 1 + .claude/worktrees/feat-provider-tests | 1 + .claude/worktrees/feat-spider | 1 + .claude/worktrees/fix-error-handling | 1 + .claude/worktrees/fix-performance | 1 + .claude/worktrees/fix-quick-wins | 1 + .claude/worktrees/fix-security | 1 + .claude/worktrees/fix-type-safety | 1 + .claude/worktrees/issue-330-cli-logging-pack-perf | 1 + .claude/worktrees/passthrough-mode | 1 + .claude/worktrees/refactor-cli-decompose | 1 + .claude/worktrees/refactor-mcp-decompose | 1 + src/cli/index.ts | 9 +++++---- src/core/dedup.ts | 2 +- src/core/search.ts | 4 ++-- src/core/tags.ts | 2 +- src/core/url-fetcher.ts | 2 +- src/web/dashboard.ts | 5 ++--- src/web/server.ts | 2 +- tests/unit/batch-search.test.ts | 3 +-- tests/unit/dedup.test.ts | 2 +- tests/unit/obsidian.test.ts | 7 +++++-- tests/unit/parsers.test.ts | 3 ++- tests/unit/registry/publish.test.ts | 3 ++- tests/unit/reindex.test.ts | 4 ++-- tests/unit/search.test.ts | 15 ++++++++++----- 42 files changed, 64 insertions(+), 27 deletions(-) create mode 160000 .claude/worktrees/agent-a09c3d7c create mode 160000 .claude/worktrees/agent-a1c56452 create mode 160000 .claude/worktrees/agent-a327b0c2 create mode 160000 .claude/worktrees/agent-a462be71/.claude/worktrees/agent-a5e65331 create mode 160000 .claude/worktrees/agent-a51ac752 create mode 160000 .claude/worktrees/agent-a662428a create mode 160000 .claude/worktrees/agent-a802499a create mode 160000 .claude/worktrees/agent-a886725f create mode 160000 .claude/worktrees/agent-a8d7741c create mode 160000 .claude/worktrees/agent-a8f0cb8d create mode 160000 .claude/worktrees/agent-ab455ec1 create mode 160000 .claude/worktrees/agent-abffe11f create mode 160000 .claude/worktrees/agent-aca555c0 create mode 160000 .claude/worktrees/agent-ad3369ec create mode 160000 .claude/worktrees/agent-af29ee1c create mode 160000 .claude/worktrees/agent-af8e138d create mode 160000 .claude/worktrees/feat-integration-tests create mode 160000 .claude/worktrees/feat-provider-tests create mode 160000 .claude/worktrees/feat-spider create mode 160000 .claude/worktrees/fix-error-handling create mode 160000 .claude/worktrees/fix-performance create mode 160000 .claude/worktrees/fix-quick-wins create mode 160000 .claude/worktrees/fix-security create mode 160000 .claude/worktrees/fix-type-safety create mode 160000 .claude/worktrees/issue-330-cli-logging-pack-perf create mode 160000 .claude/worktrees/passthrough-mode create mode 160000 .claude/worktrees/refactor-cli-decompose create mode 160000 .claude/worktrees/refactor-mcp-decompose diff --git a/.claude/worktrees/agent-a09c3d7c b/.claude/worktrees/agent-a09c3d7c new file mode 160000 index 0000000..a1e75e6 --- /dev/null +++ b/.claude/worktrees/agent-a09c3d7c @@ -0,0 +1 @@ +Subproject commit a1e75e6b76f9ada4369d969c397d6c5aed6255f6 diff --git a/.claude/worktrees/agent-a1c56452 b/.claude/worktrees/agent-a1c56452 new file mode 160000 index 0000000..5f35206 --- /dev/null +++ b/.claude/worktrees/agent-a1c56452 @@ -0,0 +1 @@ +Subproject commit 5f3520658d949372276bf27be0aa8b2ff0d9193c diff --git a/.claude/worktrees/agent-a327b0c2 b/.claude/worktrees/agent-a327b0c2 new file mode 160000 index 0000000..b61747f --- /dev/null +++ b/.claude/worktrees/agent-a327b0c2 @@ -0,0 +1 @@ +Subproject commit b61747fb164909e9d8d79955685eb4d130f9dbe9 diff --git a/.claude/worktrees/agent-a462be71/.claude/worktrees/agent-a5e65331 b/.claude/worktrees/agent-a462be71/.claude/worktrees/agent-a5e65331 new file mode 160000 index 0000000..061b963 --- /dev/null +++ b/.claude/worktrees/agent-a462be71/.claude/worktrees/agent-a5e65331 @@ -0,0 +1 @@ +Subproject commit 061b96336a0a1971e82737d42b3278a38eb576c6 diff --git a/.claude/worktrees/agent-a51ac752 b/.claude/worktrees/agent-a51ac752 new file mode 160000 index 0000000..13c9a44 --- /dev/null +++ b/.claude/worktrees/agent-a51ac752 @@ -0,0 +1 @@ +Subproject commit 13c9a44967435ac4e4dd08680597602c127b2985 diff --git a/.claude/worktrees/agent-a662428a b/.claude/worktrees/agent-a662428a new file mode 160000 index 0000000..edf3802 --- /dev/null +++ b/.claude/worktrees/agent-a662428a @@ -0,0 +1 @@ +Subproject commit edf380273e98942deeec978d9e773e73ec96a02c diff --git a/.claude/worktrees/agent-a802499a b/.claude/worktrees/agent-a802499a new file mode 160000 index 0000000..3f27bbf --- /dev/null +++ b/.claude/worktrees/agent-a802499a @@ -0,0 +1 @@ +Subproject commit 3f27bbf38eaad7bb9d9a0f7191abc62e7b8ce685 diff --git a/.claude/worktrees/agent-a886725f b/.claude/worktrees/agent-a886725f new file mode 160000 index 0000000..bf6e1be --- /dev/null +++ b/.claude/worktrees/agent-a886725f @@ -0,0 +1 @@ +Subproject commit bf6e1bebc6d6d30bb553cfdb98801488efae56bf diff --git a/.claude/worktrees/agent-a8d7741c b/.claude/worktrees/agent-a8d7741c new file mode 160000 index 0000000..7f4c339 --- /dev/null +++ b/.claude/worktrees/agent-a8d7741c @@ -0,0 +1 @@ +Subproject commit 7f4c33968fcc94268e1281b0b23335abc5c2ea85 diff --git a/.claude/worktrees/agent-a8f0cb8d b/.claude/worktrees/agent-a8f0cb8d new file mode 160000 index 0000000..49f9da1 --- /dev/null +++ b/.claude/worktrees/agent-a8f0cb8d @@ -0,0 +1 @@ +Subproject commit 49f9da196c3650575eba0f1ab93aac8efe327137 diff --git a/.claude/worktrees/agent-ab455ec1 b/.claude/worktrees/agent-ab455ec1 new file mode 160000 index 0000000..5f35206 --- /dev/null +++ b/.claude/worktrees/agent-ab455ec1 @@ -0,0 +1 @@ +Subproject commit 5f3520658d949372276bf27be0aa8b2ff0d9193c diff --git a/.claude/worktrees/agent-abffe11f b/.claude/worktrees/agent-abffe11f new file mode 160000 index 0000000..bf6e1be --- /dev/null +++ b/.claude/worktrees/agent-abffe11f @@ -0,0 +1 @@ +Subproject commit bf6e1bebc6d6d30bb553cfdb98801488efae56bf diff --git a/.claude/worktrees/agent-aca555c0 b/.claude/worktrees/agent-aca555c0 new file mode 160000 index 0000000..f8ae7c2 --- /dev/null +++ b/.claude/worktrees/agent-aca555c0 @@ -0,0 +1 @@ +Subproject commit f8ae7c2badfc4b27660afcc3dec28a23c0b723cf diff --git a/.claude/worktrees/agent-ad3369ec b/.claude/worktrees/agent-ad3369ec new file mode 160000 index 0000000..5f35206 --- /dev/null +++ b/.claude/worktrees/agent-ad3369ec @@ -0,0 +1 @@ +Subproject commit 5f3520658d949372276bf27be0aa8b2ff0d9193c diff --git a/.claude/worktrees/agent-af29ee1c b/.claude/worktrees/agent-af29ee1c new file mode 160000 index 0000000..015b533 --- /dev/null +++ b/.claude/worktrees/agent-af29ee1c @@ -0,0 +1 @@ +Subproject commit 015b533d3e65b8e3e7ca866c3265b0627dca0ca6 diff --git a/.claude/worktrees/agent-af8e138d b/.claude/worktrees/agent-af8e138d new file mode 160000 index 0000000..bf6e1be --- /dev/null +++ b/.claude/worktrees/agent-af8e138d @@ -0,0 +1 @@ +Subproject commit bf6e1bebc6d6d30bb553cfdb98801488efae56bf diff --git a/.claude/worktrees/feat-integration-tests b/.claude/worktrees/feat-integration-tests new file mode 160000 index 0000000..3c5364e --- /dev/null +++ b/.claude/worktrees/feat-integration-tests @@ -0,0 +1 @@ +Subproject commit 3c5364e49e2a7071eb68167c72efa8b0e0b058d4 diff --git a/.claude/worktrees/feat-provider-tests b/.claude/worktrees/feat-provider-tests new file mode 160000 index 0000000..35faeb1 --- /dev/null +++ b/.claude/worktrees/feat-provider-tests @@ -0,0 +1 @@ +Subproject commit 35faeb1247ab25ce9914e1ef2041ceeeb69f0d19 diff --git a/.claude/worktrees/feat-spider b/.claude/worktrees/feat-spider new file mode 160000 index 0000000..71b1cab --- /dev/null +++ b/.claude/worktrees/feat-spider @@ -0,0 +1 @@ +Subproject commit 71b1cab873f737d746a0bfd9d5d2bc6d57d86cc1 diff --git a/.claude/worktrees/fix-error-handling b/.claude/worktrees/fix-error-handling new file mode 160000 index 0000000..f1c1b19 --- /dev/null +++ b/.claude/worktrees/fix-error-handling @@ -0,0 +1 @@ +Subproject commit f1c1b19de378ca5382785485cbd522c4ccb14500 diff --git a/.claude/worktrees/fix-performance b/.claude/worktrees/fix-performance new file mode 160000 index 0000000..9a33416 --- /dev/null +++ b/.claude/worktrees/fix-performance @@ -0,0 +1 @@ +Subproject commit 9a33416de914953a21ef7725666c016fc309a9e5 diff --git a/.claude/worktrees/fix-quick-wins b/.claude/worktrees/fix-quick-wins new file mode 160000 index 0000000..9ac1262 --- /dev/null +++ b/.claude/worktrees/fix-quick-wins @@ -0,0 +1 @@ +Subproject commit 9ac1262e9914f1e365152919a40735f515bfccd9 diff --git a/.claude/worktrees/fix-security b/.claude/worktrees/fix-security new file mode 160000 index 0000000..cc2df04 --- /dev/null +++ b/.claude/worktrees/fix-security @@ -0,0 +1 @@ +Subproject commit cc2df047a397c2ce9fff2a4b15431a035c01b0aa diff --git a/.claude/worktrees/fix-type-safety b/.claude/worktrees/fix-type-safety new file mode 160000 index 0000000..26f2c4b --- /dev/null +++ b/.claude/worktrees/fix-type-safety @@ -0,0 +1 @@ +Subproject commit 26f2c4b36b77cb9b6541434f6cdfe44d84512fa9 diff --git a/.claude/worktrees/issue-330-cli-logging-pack-perf b/.claude/worktrees/issue-330-cli-logging-pack-perf new file mode 160000 index 0000000..d5dae05 --- /dev/null +++ b/.claude/worktrees/issue-330-cli-logging-pack-perf @@ -0,0 +1 @@ +Subproject commit d5dae051782aa368b9c9ddfefd6771598e6ba349 diff --git a/.claude/worktrees/passthrough-mode b/.claude/worktrees/passthrough-mode new file mode 160000 index 0000000..b3f6965 --- /dev/null +++ b/.claude/worktrees/passthrough-mode @@ -0,0 +1 @@ +Subproject commit b3f6965499448eaf098d87ed1bd74077106aedfd diff --git a/.claude/worktrees/refactor-cli-decompose b/.claude/worktrees/refactor-cli-decompose new file mode 160000 index 0000000..bb0b1e3 --- /dev/null +++ b/.claude/worktrees/refactor-cli-decompose @@ -0,0 +1 @@ +Subproject commit bb0b1e3b899de34dc642b88fc3d1f7645a671047 diff --git a/.claude/worktrees/refactor-mcp-decompose b/.claude/worktrees/refactor-mcp-decompose new file mode 160000 index 0000000..9892601 --- /dev/null +++ b/.claude/worktrees/refactor-mcp-decompose @@ -0,0 +1 @@ +Subproject commit 98926016be2d607a9ce1c545f6d50e494fa42236 diff --git a/src/cli/index.ts b/src/cli/index.ts index 58031c0..ef71e9f 100644 --- a/src/cli/index.ts +++ b/src/cli/index.ts @@ -69,15 +69,16 @@ import { syncOneNote, disconnectOneNote, } from "../connectors/onenote.js"; -import { loadConnectorConfig, saveConnectorConfig } from "../connectors/index.js"; -import { syncNotion, disconnectNotion } from "../connectors/notion.js"; -import type { NotionConfig } from "../connectors/notion.js"; -import { syncSlack, disconnectSlack, type SlackConfig } from "../connectors/slack.js"; import { + loadConnectorConfig, + saveConnectorConfig, saveNamedConnectorConfig, loadNamedConnectorConfig, hasNamedConnectorConfig, } from "../connectors/index.js"; +import { syncNotion, disconnectNotion } from "../connectors/notion.js"; +import type { NotionConfig } from "../connectors/notion.js"; +import { syncSlack, disconnectSlack, type SlackConfig } from "../connectors/slack.js"; import { createSavedSearch, listSavedSearches, diff --git a/src/core/dedup.ts b/src/core/dedup.ts index 0166353..a2653de 100644 --- a/src/core/dedup.ts +++ b/src/core/dedup.ts @@ -77,7 +77,7 @@ export async function checkDuplicate( if (row) { log.debug({ existingDocId: row.id }, "Exact duplicate detected via content hash"); - return { isDuplicate: true, matchType: "exact", existingDocId: row.id, similarity: 1.0 }; + return { isDuplicate: true, matchType: "exact", existingDocId: row.id, similarity: 1 }; } } diff --git a/src/core/search.ts b/src/core/search.ts index 214182e..cdd565a 100644 --- a/src/core/search.ts +++ b/src/core/search.ts @@ -183,7 +183,7 @@ function computeRrfScores(map: Map): SearchResult[] { for (const item of map.values()) { let rrfScore = 0; for (const rank of item.ranks) { - rrfScore += 1.0 / (RRF_K + rank); + rrfScore += 1 / (RRF_K + rank); } const boostFactors = [...item.result.scoreExplanation.boostFactors]; fused.push({ @@ -826,7 +826,7 @@ export function getRelatedChunks( ): RelatedChunksResult { const { chunkId } = options; const limit = Math.max(1, Math.min(options.limit ?? 10, 1000)); - const minScore = options.minScore ?? 0.0; + const minScore = options.minScore ?? 0; // Look up the source chunk const SourceChunkSchema = z.object({ diff --git a/src/core/tags.ts b/src/core/tags.ts index 1dc38e1..2f85b69 100644 --- a/src/core/tags.ts +++ b/src/core/tags.ts @@ -462,7 +462,7 @@ export function suggestTags( for (const [term, count] of tf) { if (existingTags.has(term)) continue; const normalizedTf = count / maxTf; - const knownBoost = knownTags.has(term) ? 2.0 : 1.0; + const knownBoost = knownTags.has(term) ? 2 : 1; scored.push({ term, score: normalizedTf * knownBoost }); } diff --git a/src/core/url-fetcher.ts b/src/core/url-fetcher.ts index 1377ef5..5f721c3 100644 --- a/src/core/url-fetcher.ts +++ b/src/core/url-fetcher.ts @@ -123,7 +123,7 @@ async function validateUrl(url: string, allowPrivateUrls = false): Promise { - const reader = response.body?.getReader() as ReadableStreamDefaultReader | undefined; + const reader = response.body?.getReader(); if (!reader) { // Fallback: body is not streamable const text = await response.text(); diff --git a/src/web/dashboard.ts b/src/web/dashboard.ts index 9b980ea..06ea574 100644 --- a/src/web/dashboard.ts +++ b/src/web/dashboard.ts @@ -143,10 +143,9 @@ export function getDashboardHtml(): string { async function loadTopics() { try { const topics = await api('/api/topics'); - let html = '
  • All Documents
    • '; + let html = `
  • All Documents
    • `; for (const t of topics) { - html += '
  • ' - + '' + esc(t.name) + '' + (t.documentCount || 0) + '
    • '; + html += `
  • ${esc(t.name)}${t.documentCount || 0}
    • `; } $topicList.innerHTML = html; } catch (e) { console.error('loadTopics failed', e); } diff --git a/src/web/server.ts b/src/web/server.ts index 38e97e9..b3a239e 100644 --- a/src/web/server.ts +++ b/src/web/server.ts @@ -46,7 +46,7 @@ export function startWebServer( }); server.on("error", reject); - server.listen(port, host, () => resolve(server!)); + server.listen(port, host, () => resolve(server)); }); } diff --git a/tests/unit/batch-search.test.ts b/tests/unit/batch-search.test.ts index 023a5e0..b887d80 100644 --- a/tests/unit/batch-search.test.ts +++ b/tests/unit/batch-search.test.ts @@ -2,8 +2,7 @@ import { describe, it, expect, beforeEach, afterEach } from "vitest"; import type Database from "better-sqlite3"; import { createTestDbWithVec } from "../fixtures/test-db.js"; import { MockEmbeddingProvider } from "../fixtures/mock-provider.js"; -import { seedTestDocument } from "../fixtures/helpers.js"; -import { insertChunk } from "../fixtures/helpers.js"; +import { seedTestDocument, insertChunk } from "../fixtures/helpers.js"; import { searchBatch, BATCH_SEARCH_MAX_REQUESTS, diff --git a/tests/unit/dedup.test.ts b/tests/unit/dedup.test.ts index 31d1ab8..56e7b30 100644 --- a/tests/unit/dedup.test.ts +++ b/tests/unit/dedup.test.ts @@ -43,7 +43,7 @@ describe("dedup", () => { expect(result.isDuplicate).toBe(true); expect(result.matchType).toBe("exact"); - expect(result.similarity).toBe(1.0); + expect(result.similarity).toBe(1); expect(result.existingDocId).toBeDefined(); }); diff --git a/tests/unit/obsidian.test.ts b/tests/unit/obsidian.test.ts index 42af44a..4787d18 100644 --- a/tests/unit/obsidian.test.ts +++ b/tests/unit/obsidian.test.ts @@ -1,5 +1,9 @@ import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"; -import { parseObsidianMarkdown } from "../../src/connectors/obsidian.js"; +import { + parseObsidianMarkdown, + syncObsidianVault, + disconnectVault, +} from "../../src/connectors/obsidian.js"; import { createTestDb, createTestDbWithVec } from "../fixtures/test-db.js"; import { MockEmbeddingProvider } from "../fixtures/mock-provider.js"; import type Database from "better-sqlite3"; @@ -29,7 +33,6 @@ vi.mock("node:fs/promises", async (importOriginal) => { }); import { readdirSync, readFileSync, statSync, existsSync, writeFileSync } from "node:fs"; -import { syncObsidianVault, disconnectVault } from "../../src/connectors/obsidian.js"; import { initLogger } from "../../src/logger.js"; const mockedReaddirSync = vi.mocked(readdirSync); diff --git a/tests/unit/parsers.test.ts b/tests/unit/parsers.test.ts index a49f29a..c6495c4 100644 --- a/tests/unit/parsers.test.ts +++ b/tests/unit/parsers.test.ts @@ -174,7 +174,8 @@ describe("CsvParser", () => { it("escapes pipe characters in cell values", async () => { const input = "col1,col2\nfoo|bar,baz"; const result = await parser.parse(Buffer.from(input)); - expect(result).toContain("foo\\|bar"); + // prettier-ignore + expect(result).toContain(String.raw`foo\|bar`); }); it("replaces newlines in cell values", async () => { diff --git a/tests/unit/registry/publish.test.ts b/tests/unit/registry/publish.test.ts index 69bad36..aeff724 100644 --- a/tests/unit/registry/publish.test.ts +++ b/tests/unit/registry/publish.test.ts @@ -184,7 +184,8 @@ describe("registry publish", () => { addTestRegistry(makeEntry(regName, bareUrl)); const packFile = join(tempDir, "backslash.json"); - writeFileSync(packFile, JSON.stringify(makePackJson("foo\\bar")), "utf-8"); + // prettier-ignore + writeFileSync(packFile, JSON.stringify(makePackJson(String.raw`foo\bar`)), "utf-8"); await expect(publishPack({ registryName: regName, packFilePath: packFile })).rejects.toThrow( /path separators/i, diff --git a/tests/unit/reindex.test.ts b/tests/unit/reindex.test.ts index f6b5646..6ae389e 100644 --- a/tests/unit/reindex.test.ts +++ b/tests/unit/reindex.test.ts @@ -30,10 +30,10 @@ function createMockProvider(overrides?: Partial): MockProvide name: "mock", dimensions: 384, embed: vi.fn().mockResolvedValue(new Array(384).fill(0)), - embedBatch: embedBatchFn as EmbeddingProvider["embedBatch"], + embedBatch: embedBatchFn, ...overrides, }; - return { provider, embedBatchFn: embedBatchFn as ReturnType }; + return { provider, embedBatchFn: embedBatchFn }; } interface MockStmt { diff --git a/tests/unit/search.test.ts b/tests/unit/search.test.ts index fa09241..c6c77a2 100644 --- a/tests/unit/search.test.ts +++ b/tests/unit/search.test.ts @@ -260,24 +260,29 @@ describe("searchDocuments (FTS5 fallback)", () => { }); describe("escapeLikePattern", () => { + // prettier-ignore it("escapes % wildcard", () => { - expect(escapeLikePattern("100%")).toBe("100\\%"); + expect(escapeLikePattern("100%")).toBe(String.raw`100\%`); }); + // prettier-ignore it("escapes _ wildcard", () => { - expect(escapeLikePattern("user_name")).toBe("user\\_name"); + expect(escapeLikePattern("user_name")).toBe(String.raw`user\_name`); }); + // prettier-ignore it("escapes [ bracket", () => { - expect(escapeLikePattern("arr[0]")).toBe("arr\\[0]"); + expect(escapeLikePattern("arr[0]")).toBe(String.raw`arr\[0]`); }); + // prettier-ignore it("escapes backslash", () => { - expect(escapeLikePattern("path\\file")).toBe("path\\\\file"); + expect(escapeLikePattern("path\\file")).toBe(String.raw`path\\file`); }); + // prettier-ignore it("escapes multiple special characters", () => { - expect(escapeLikePattern("100%_[test]")).toBe("100\\%\\_\\[test]"); + expect(escapeLikePattern("100%_[test]")).toBe(String.raw`100\%\_\[test]`); }); it("returns plain strings unchanged", () => { From 80a68b0507d8de2b0f6c94e29febac0e91e2f7b0 Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 00:45:37 +0000 Subject: [PATCH 3/9] fix: revert dashboard.ts String.raw changes that broke HTML template The dashboard.ts file is one large template literal exporting HTML+JS. The \' escapes produce literal quotes in onclick handlers and cannot be converted to String.raw or template literals without breaking the nested quoting. Co-Authored-By: Claude Opus 4.6 (1M context) --- src/web/dashboard.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/web/dashboard.ts b/src/web/dashboard.ts index 06ea574..9b980ea 100644 --- a/src/web/dashboard.ts +++ b/src/web/dashboard.ts @@ -143,9 +143,10 @@ export function getDashboardHtml(): string { async function loadTopics() { try { const topics = await api('/api/topics'); - let html = `
  • All Documents
    • `; + let html = '
  • All Documents
    • '; for (const t of topics) { - html += `
  • ${esc(t.name)}${t.documentCount || 0}
    • `; + html += '
  • ' + + '' + esc(t.name) + '' + (t.documentCount || 0) + '
    • '; } $topicList.innerHTML = html; } catch (e) { console.error('loadTopics failed', e); } From f1dba016e34711948c74dba39d6ce036715ed666 Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 00:55:59 +0000 Subject: [PATCH 4/9] fix: restore type assertion in url-fetcher.ts readBodyWithLimit The `as ReadableStreamDefaultReader` cast is needed because Node.js type definitions return `any` from getReader(). Removing it introduces no-unsafe-assignment lint errors in CI. Co-Authored-By: Claude Opus 4.6 (1M context) --- src/core/url-fetcher.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/url-fetcher.ts b/src/core/url-fetcher.ts index 5f721c3..1377ef5 100644 --- a/src/core/url-fetcher.ts +++ b/src/core/url-fetcher.ts @@ -123,7 +123,7 @@ async function validateUrl(url: string, allowPrivateUrls = false): Promise { - const reader = response.body?.getReader(); + const reader = response.body?.getReader() as ReadableStreamDefaultReader | undefined; if (!reader) { // Fallback: body is not streamable const text = await response.text(); From e1c8939e3f779fc9046afda73ad263605cd7fa13 Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 01:00:03 +0000 Subject: [PATCH 5/9] fix: restore type assertions in watcher/reindex tests for Node 22 compat The `as Stats` and `as ReturnType` casts are needed for TypeScript type resolution under Node 22's stricter type definitions in CI. Removing them causes cascading no-unsafe-call errors. Co-Authored-By: Claude Opus 4.6 (1M context) --- tests/unit/reindex.test.ts | 4 ++-- tests/unit/watcher.test.ts | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/unit/reindex.test.ts b/tests/unit/reindex.test.ts index 6ae389e..f6b5646 100644 --- a/tests/unit/reindex.test.ts +++ b/tests/unit/reindex.test.ts @@ -30,10 +30,10 @@ function createMockProvider(overrides?: Partial): MockProvide name: "mock", dimensions: 384, embed: vi.fn().mockResolvedValue(new Array(384).fill(0)), - embedBatch: embedBatchFn, + embedBatch: embedBatchFn as EmbeddingProvider["embedBatch"], ...overrides, }; - return { provider, embedBatchFn: embedBatchFn }; + return { provider, embedBatchFn: embedBatchFn as ReturnType }; } interface MockStmt { diff --git a/tests/unit/watcher.test.ts b/tests/unit/watcher.test.ts index 87d6756..394be10 100644 --- a/tests/unit/watcher.test.ts +++ b/tests/unit/watcher.test.ts @@ -111,7 +111,7 @@ describe("FileWatcher", () => { watcher.start(); - mockStatSync.mockReturnValue({ isFile: () => true }); + mockStatSync.mockReturnValue({ isFile: () => true } as import("node:fs").Stats); mockReadFileSync.mockReturnValue("content"); watchCallback("change", "file.md"); @@ -135,12 +135,12 @@ describe("FileWatcher", () => { const onIndex = vi.fn(); const contentHash = createHash("sha256").update("hello").digest("hex"); - db.prepare.mockReturnValue({ + (db.prepare as ReturnType).mockReturnValue({ get: vi.fn().mockReturnValue({ id: "doc-1", content_hash: contentHash }), run: vi.fn(), }); - mockStatSync.mockReturnValue({ isFile: () => true }); + mockStatSync.mockReturnValue({ isFile: () => true } as import("node:fs").Stats); mockReadFileSync.mockReturnValue("hello"); const watcher = new FileWatcher(db, provider, { @@ -165,7 +165,7 @@ describe("FileWatcher", () => { const onRemove = vi.fn(); const runFn = vi.fn(); - db.prepare.mockReturnValue({ + (db.prepare as ReturnType).mockReturnValue({ get: vi.fn().mockReturnValue({ id: "doc-1" }), run: runFn, }); @@ -256,7 +256,7 @@ describe("FileWatcher", () => { const provider = createMockProvider(); const onIndex = vi.fn(); - mockStatSync.mockReturnValue({ isFile: () => false }); + mockStatSync.mockReturnValue({ isFile: () => false } as import("node:fs").Stats); const watcher = new FileWatcher(db, provider, { directory: "/tmp/docs", @@ -280,7 +280,7 @@ describe("FileWatcher", () => { const onRemove = vi.fn(); // Return undefined for document lookup (no existing doc) - db.prepare.mockReturnValue({ + (db.prepare as ReturnType).mockReturnValue({ get: vi.fn().mockReturnValue(undefined), run: vi.fn(), }); From 055576597b8e2b7df04ca9804746abc7defb2b57 Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 01:02:04 +0000 Subject: [PATCH 6/9] fix: restore non-null assertion in server.ts Co-Authored-By: Claude Opus 4.6 (1M context) --- src/web/server.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/web/server.ts b/src/web/server.ts index b3a239e..38e97e9 100644 --- a/src/web/server.ts +++ b/src/web/server.ts @@ -46,7 +46,7 @@ export function startWebServer( }); server.on("error", reject); - server.listen(port, host, () => resolve(server)); + server.listen(port, host, () => resolve(server!)); }); } From f89ebb7e9b2f7c58316523d47cca8722bd57fbcd Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 01:07:51 +0000 Subject: [PATCH 7/9] fix: convert remaining .replace(/g) to .replaceAll() in packs, csv, search Co-Authored-By: Claude Opus 4.6 (1M context) --- src/core/packs.ts | 8 ++++---- src/core/parsers/csv.ts | 2 +- src/core/search.ts | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/core/packs.ts b/src/core/packs.ts index 1489ea3..5dd65b1 100644 --- a/src/core/packs.ts +++ b/src/core/packs.ts @@ -693,10 +693,10 @@ function matchesExcludePattern(relativePath: string, pattern: string): boolean { // Escape regex special chars except * and ** // prettier-ignore const escaped = pattern - .replace(/[.+^${}()|[\]\\]/g, String.raw`\$&`) - .replace(/\*\*/g, "\0") - .replace(/\*/g, "[^/]*") - .replace(/\0/g, ".*"); + .replaceAll(/[.+^${}()|[\]\\]/g, String.raw`\$&`) + .replaceAll("**", "\0") + .replaceAll("*", "[^/]*") + .replaceAll("\0", ".*"); return new RegExp(`^${escaped}$`).test(relativePath); } diff --git a/src/core/parsers/csv.ts b/src/core/parsers/csv.ts index 4048c04..810517e 100644 --- a/src/core/parsers/csv.ts +++ b/src/core/parsers/csv.ts @@ -20,7 +20,7 @@ export class CsvParser implements DocumentParser { // prettier-ignore const escapeCell = (cell: string): string => - cell.replace(/\\/g, String.raw`\\`).replace(/\|/g, String.raw`\|`).replace(/\n/g, " "); + cell.replaceAll("\\", String.raw`\\`).replaceAll("|", String.raw`\|`).replaceAll("\n", " "); const lines: string[] = []; lines.push("| " + header.map(escapeCell).join(" | ") + " |"); diff --git a/src/core/search.ts b/src/core/search.ts index cdd565a..a6cfe19 100644 --- a/src/core/search.ts +++ b/src/core/search.ts @@ -41,10 +41,10 @@ function isVectorTableError(err: unknown): boolean { export function escapeLikePattern(input: string): string { // prettier-ignore return input - .replace(/\\/g, String.raw`\\`) - .replace(/%/g, String.raw`\%`) - .replace(/_/g, String.raw`\_`) - .replace(/\[/g, String.raw`\[`); + .replaceAll("\\", String.raw`\\`) + .replaceAll("%", String.raw`\%`) + .replaceAll("_", String.raw`\_`) + .replaceAll("[", String.raw`\[`); } export interface SearchOptions { From 55979fded737025e16beb8e69c90e523aa2ce6bb Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 01:10:30 +0000 Subject: [PATCH 8/9] fix: combine consecutive Array.push calls (S7778) Co-Authored-By: Claude Opus 4.6 (1M context) --- src/core/parsers/csv.ts | 6 ++++-- src/core/search.ts | 9 +++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/core/parsers/csv.ts b/src/core/parsers/csv.ts index 810517e..8d13271 100644 --- a/src/core/parsers/csv.ts +++ b/src/core/parsers/csv.ts @@ -23,8 +23,10 @@ export class CsvParser implements DocumentParser { cell.replaceAll("\\", String.raw`\\`).replaceAll("|", String.raw`\|`).replaceAll("\n", " "); const lines: string[] = []; - lines.push("| " + header.map(escapeCell).join(" | ") + " |"); - lines.push("| " + header.map(() => "---").join(" | ") + " |"); + lines.push( + "| " + header.map(escapeCell).join(" | ") + " |", + "| " + header.map(() => "---").join(" | ") + " |", + ); for (const row of rows) { // Normalize row length to match header const normalized = Array.from({ length: colCount }, (_, i) => row[i] ?? ""); diff --git a/src/core/search.ts b/src/core/search.ts index a6cfe19..29f8e49 100644 --- a/src/core/search.ts +++ b/src/core/search.ts @@ -719,8 +719,7 @@ function keywordSearch( const baseParams = [...params]; sql += " LIMIT ? OFFSET ?"; - params.push(limit); - params.push(offset); + params.push(limit, offset); const KeywordRowSchema = z.object({ chunk_id: z.string(), @@ -1087,8 +1086,7 @@ function fts5Search( let baseParams = [...params]; sql += " ORDER BY rank LIMIT ? OFFSET ?"; - params.push(limit); - params.push(offset); + params.push(limit, offset); const Fts5RowSchema = z.object({ chunk_id: z.string(), @@ -1141,8 +1139,7 @@ function fts5Search( baseParams = [...orParams]; orSql += " ORDER BY rank LIMIT ? OFFSET ?"; - orParams.push(limit); - orParams.push(offset); + orParams.push(limit, offset); rows = validateRows(Fts5RowSchema, db.prepare(orSql).all(...orParams), "fts5Search.orRows"); } From d56c44694d3c12c925c5cc43ecc46f4f37d7b859 Mon Sep 17 00:00:00 2001 From: Robert DeRienzo Date: Thu, 19 Mar 2026 01:15:24 +0000 Subject: [PATCH 9/9] fix: revert String.raw in search test assertions to reduce duplication density The String.raw conversions in test assertions added prettier-ignore comments that inflated SonarCloud's duplication density metric (18% vs 3% threshold). The original escaped strings were already correct. Co-Authored-By: Claude Opus 4.6 (1M context) --- tests/unit/search.test.ts | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/tests/unit/search.test.ts b/tests/unit/search.test.ts index c6c77a2..fa09241 100644 --- a/tests/unit/search.test.ts +++ b/tests/unit/search.test.ts @@ -260,29 +260,24 @@ describe("searchDocuments (FTS5 fallback)", () => { }); describe("escapeLikePattern", () => { - // prettier-ignore it("escapes % wildcard", () => { - expect(escapeLikePattern("100%")).toBe(String.raw`100\%`); + expect(escapeLikePattern("100%")).toBe("100\\%"); }); - // prettier-ignore it("escapes _ wildcard", () => { - expect(escapeLikePattern("user_name")).toBe(String.raw`user\_name`); + expect(escapeLikePattern("user_name")).toBe("user\\_name"); }); - // prettier-ignore it("escapes [ bracket", () => { - expect(escapeLikePattern("arr[0]")).toBe(String.raw`arr\[0]`); + expect(escapeLikePattern("arr[0]")).toBe("arr\\[0]"); }); - // prettier-ignore it("escapes backslash", () => { - expect(escapeLikePattern("path\\file")).toBe(String.raw`path\\file`); + expect(escapeLikePattern("path\\file")).toBe("path\\\\file"); }); - // prettier-ignore it("escapes multiple special characters", () => { - expect(escapeLikePattern("100%_[test]")).toBe(String.raw`100\%\_\[test]`); + expect(escapeLikePattern("100%_[test]")).toBe("100\\%\\_\\[test]"); }); it("returns plain strings unchanged", () => {