Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: event is undefined. #27

Closed
gamame opened this issue Jul 25, 2017 · 1 comment
Closed

Bug: event is undefined. #27

gamame opened this issue Jul 25, 2017 · 1 comment

Comments

@gamame
Copy link

gamame commented Jul 25, 2017

event is undefined error by firefox .

  openPicker() {
        ...
        this._onTooltipClick(tooltip, event);  <- this is undefined.
        ...
  }

and I want to change rm-tooltip#setClickCallback;

Tooltip.prototype.setClickCallback = function(event, func){

    if (event) {
      event.stopPropagation();
    }

    this._unique = 'click.' + new Date().getTime();

    $("html").on(this._unique, event => {
        func.call(this, event.target, this.$tooltip);
    });
};

@RobertMenke
Copy link
Owner

RobertMenke commented Jul 29, 2017

@dondoco7 This was an AWESOME catch thank you for reporting this issue! Instead of changing the tooltip library I just fixed the reference error in the emoji picker by passing the MouseEvent to openPicker() in this PR #28.

Please re-open if this doesn't fix your issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants