splice with a single argument is not supported in ie<=8, so replaced it with slice(arguments, 1) #2

Merged
merged 3 commits into from Apr 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

hughfdjackson commented Apr 5, 2012

Also, the test suite didn't catch it, so I used TDD on the fix.

RobertWHurst pushed a commit that referenced this pull request Apr 5, 2012

Merge pull request #2 from hughfdjackson/master
splice with a single argument is not supported in ie<=8, so replaced it with slice(arguments, 1)

@RobertWHurst RobertWHurst merged commit 54c53ca into RobertWHurst:master Apr 5, 2012

Contributor

hughfdjackson commented Apr 6, 2012

Hurrah! thanks very much matey.

Owner

RobertWHurst commented Apr 7, 2012

No problem. If anyone sends me a request that is helpful I'll merge it in.

add0n commented Jun 4, 2012

We're abandoning 'mu' in favor of handlebars, which we will integrate via:

yahoo/mojito#179

Therefore, we're not patching 'mu' anymore.

Owner

RobertWHurst commented Jun 4, 2012

@add0n I think I'm out of the loop... What?

add0n commented Jun 6, 2012

FYI, due to other projects being dependent on 'mu', we're testing your fix now and will release it. Thanks.

add0n commented Jun 6, 2012

Sorry, I'm confusing the issue. We're testing another pull request. Ignore these comments :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment