Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Networks without encryption marked as insecure #6

Merged
merged 3 commits into from Nov 5, 2011

Conversation

Projects
None yet
2 participants
Contributor

alazaro commented Nov 2, 2011

I think this is how it should be :)

If you find it nonsense, then throw it to the bin and forget it.

Owner

RobertoEstrada commented Nov 2, 2011

I'll review it mate! Thanks for contributing! Do you have any clues on WiFi support in iOS 5?

EDIT: If you pull the latest changes from my repository it will be easier to merge your changes, i looked your changes and they were based on a previous version. Thanks!

Contributor

alazaro commented Nov 3, 2011

Thank you for sharing your project. I have no idea about WiFi in iOS 5, I haven't installed it yet.

I think I have the latest version of your code. Ain't this 7ff6a87 the last commit you made? There was an indentation mistake but I fixed it.

Owner

RobertoEstrada commented Nov 3, 2011

In the last commit you put it is right, in the previous appeared old code.

RobertoEstrada added a commit that referenced this pull request Nov 5, 2011

Merge pull request #6 from alazaro/master
Networks without encryption marked as insecure

@RobertoEstrada RobertoEstrada merged commit 0b05cd4 into RobertoEstrada:master Nov 5, 2011

Contributor

alazaro commented Nov 8, 2011

I've been doing some research on my own router and I have obtained these results: https://gist.github.com/1346672#file_tests.txt

I concluded that if you add this check [networkDetails objectForKey:@"RSN_IE"] to the other ones on https://github.com/RobertoEstrada/WLAN-Audit/blob/master/Classes/NetworkDetailsController.m#L241 you will know if the network is under WPA2 or unencrypted.

You might consider adding another field for WPA2, and maybe another one for encryption type (AES, TKIP) which I think can be obtained from the file I got.

P.S.: I'm sorry my code was a FAIL :P

Owner

RobertoEstrada commented Nov 14, 2011

That would be a great contribution!

P.S: Hablamos en inglés por si alguien que no habla español lee esto ¿no? jaja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment