Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Store.spec.lua destruct all stores #52

Merged
merged 1 commit into from Aug 10, 2020
Merged

Make Store.spec.lua destruct all stores #52

merged 1 commit into from Aug 10, 2020

Conversation

OverHash
Copy link
Contributor

This PR closes #51

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.351% when pulling 0f7ef24 on OverHash:destructure-stores into efda50f on Roblox:master.

@github-actions
Copy link

github-actions bot commented Jul 13, 2020

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@OverHash
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ZoteTheMighty
Copy link
Contributor

Hi, thanks for your contribution! This comment should kickstart the CLA bot and re-run it

@ZoteTheMighty ZoteTheMighty merged commit 9e1736a into Roblox:master Aug 10, 2020
@OverHash OverHash deleted the destructure-stores branch August 10, 2020 19:41
ZoteTheMighty pushed a commit to ZoteTheMighty/rodux that referenced this pull request Dec 2, 2020
Adds missing store:destruct call to test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store.spec.lua has an undestructed store
3 participants