Fix compiler identification for Bazel 1.1.0 on macOS #12224
Conversation
|
@drake-jenkins-bot mac-catalina-clang-bazel-experimental-release please |
|
Bazel 1.0 is past the compiler check, so everything is good. |
|
+@soonho-tri for feature review and +@jwnimmer-tri for platform review. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee soonho-tri(platform) (waiting on @jamiesnape and @soonho-tri)
tools/workspace/cc/repository.bzl, line 59 at r1 (raw file):
cc = repository_ctx.path(Label("@local_config_cc//:wrapped_clang")) result = repository_ctx.execute(["xcode-select", "--print-path"])
nit For brevity, PATH soundness, and more careful error messages -- consider using execute_or_fail from //tools/workspace:execute.bzl here. OK to dismiss.
Ditto below.
|
We had failing tests too. Fixing those properly is a little more involved, so I pushed a temporary patch. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee soonho-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jamiesnape and @soonho-tri)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jamiesnape)
jamiesnape
added
the
status: commits are properly curated
|
Note Starlark functions |
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),soonho-tri(platform) (waiting on @jwnimmer-tri and @soonho-tri)
tools/workspace/cc/repository.bzl, line 59 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
nit For brevity, PATH soundness, and more careful error messages -- consider using
execute_or_failfrom//tools/workspace:execute.bzlhere. OK to dismiss.Ditto below.
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status:
Once everyone is on Bazel 1.1.0 or above, much of this file can be simplified.
This change is