Port to C++20 spaceship operators #21423
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports about 75% of our comparisons to be spelled using https://en.cppreference.com/w/cpp/language/operator_comparison#Three-way_comparison, focusing especially on the code in
common
.While reviewing, it might help to remember how
operator<=>
works:= default
), you get all 6 comparison functions (i.e., both equality and ordering).operator==
(equality) yourself to get the last two.This change is