Time fromMsg() fix #601 #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@minggangw I probably should have confirmed with you that this is a legit issue before opening it. I did not find any tests for the fromMsg() api and jumped to the conclusions cited as problems 1 and 2 in issue #601 behind this PR. Minimally 3rd issue needs to be fixed for use in typescript. |
time.js fromMsg() - fixed invalid nanoseconds property access - improved Time#fromMsg() jsdoc time.d.ts fromMsg() - changed msg parameter type to builtin_interfaces.msg.Time - changed clockType parameter to optional - improved tsdoc - ignore eslint camelcase rule on some lines to avoid false negatives test-time.js - enhanced test to include Time#fromMsg()
minggangw
approved these changes
Mar 11, 2020
Member
minggangw
left a comment
minggangw
left a comment
There was a problem hiding this comment.
Thanks for correcting the name and LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #601.
time.js fromMsg()
time.d.ts fromMsg()
test-time.js