master to main/roscore

[beverlylytle]

Closes #74

What type of change is this?

• Bug fix in a backwards-compatible manner.
• New feature in a backwards-compatible manner.
• Breaking change: bug fix or new feature that involve incompatible API changes.
• Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
• I ran all tests on my computer and it's all green (i.e. invoke test).
• I ran lint on my computer and there are no errors (i.e. invoke check).
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

[gonzalocasas]

LGTM!

I am uncertain if -eventually- we should not just refer to ROS instead of roscore actually. It would fit the updated strings as well, and it might be even less confusing for users (potentially also correct for ROS2).

[beverlylytle]

I am uncertain if -eventually- we should not just refer to ROS instead of roscore actually. It would fit the updated strings as well, and it might be even less confusing for users (potentially also correct for ROS2).

Ah, good point. Referring to ROS does make more sense for the docstrings and the logger info. Will change.

[gonzalocasas]

👍 🚀