Fall back to mjpeg if ros_compressed is unavailable #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonl
approved these changes
Apr 17, 2019
dirk-thomas
added a commit
that referenced
this pull request
Sep 19, 2019
* fix SteadyTimer check for backported ROS versions (#71) i.e. on current kinetic * Add PngStreamer (#74) * lax rule for topic name (#77) * Add a workaround for MultipartStream constant busy state (#83) * Add a workaround for MultipartStream constant busy state * Remove C++11 features * Add "default_stream_type" parameter (#84) This allows users to specify default stream type in their .launch files. Using a "ros_compressed" stream type sometimes results in a much lower resource consumption, and having it set as a default is much nicer for end users. * update changelog * 0.2.0 * Fall back to mjpeg if ros_compressed is unavailable (#87) * Update travis config (#89) * Restream buffered frames with minimum publish rate (#88) * Restream buffered frames with minimum publish rate * Implement restreaming for ros_compressed_streamer * update changelog * 0.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, ROS's
image_transportdoes not yet support Python. For us this means that if we're trying to useros_compressedas our compression type by default, then we won't get any images from Python nodes unless we explicitly request another compression method. This is somewhat unintuitive and frustrating for our users.My proposed fix is to check whether there's a
/compressedtopic for the requested image topic and to fall back tomjpegcompression if there isn't.