Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign AuthnRequests and AuthnResponses with SHA256 #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattg-sigsci
Copy link

SHA1 is vulnerable so better to use SHA256 instead

SHA1 is vulnerable so better to use SHA256 instead
@gurshafriri
Copy link

👋 @mattg-sigsci is this going to be merged? we (at snyk) plan to add this issue to our vulnerability db when but can wait until it is mitigated.

@mattg-sigsci
Copy link
Author

@gurshafriri I don't know. It doesn't seem like RobotsAndPencils is maintaining this library. We're not using this fork anymore. Maybe one of the other forks is more maintained, perhaps Cloudflare's?

@bestbug456
Copy link

Hello @mbrevoort since there are some security concern, can you please give us some of your time for review this PR and bring it into the repository? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants