Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort input file list #37

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@bmwiedemann
Copy link
Contributor

commented Jul 29, 2019

Sort input file list
so that _readstat_parser.so builds in a reproducible way
in spite of indeterministic filesystem readdir order
and missing python/cpython#12341

See https://reproducible-builds.org/ for why this is good.

This PR was done while working on reproducible builds for openSUSE.

Sort input file list
so that _readstat_parser.so builds in a reproducible way
in spite of indeterministic filesystem readdir order
and missing python/cpython#12341

See https://reproducible-builds.org/ for why this is good.

@ofajardo ofajardo changed the base branch from master to write_label_devl Jul 29, 2019

@ofajardo

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

Thanks. Very interesting. I have merged into a dev branch I am currently working on and will be available with the next release.

@ofajardo ofajardo merged commit 614254a into Roche:write_label_devl Jul 29, 2019

@ofajardo

This comment has been minimized.

Copy link
Collaborator

commented Jul 30, 2019

@bmwiedemann Code released, version 0.2.8

bmwiedemann added a commit to bmwiedemann/cpython that referenced this pull request Jul 30, 2019

bpo-36302: Sort list of sources
when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output .so files.
Thus without the patch, builds (in disposable VMs) would usually differ.

Without this patch, all callers have to be patched individually
dugsong/libdnet#42
sass/libsass-python#212
tahoe-lafs/pycryptopp#41
yt-project/yt#2206
pyproj4/pyproj#142
pytries/datrie#49
Roche/pyreadstat#37
but that is an infinite effort.

See https://reproducible-builds.org/ for why this matters.

bmwiedemann added a commit to bmwiedemann/cpython that referenced this pull request Aug 1, 2019

bpo-36302: Sort list of sources
when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output .so files.
Thus without the patch, builds (in disposable VMs) would usually differ.

Without this patch, all callers have to be patched individually
dugsong/libdnet#42
sass/libsass-python#212
tahoe-lafs/pycryptopp#41
yt-project/yt#2206
pyproj4/pyproj#142
pytries/datrie#49
Roche/pyreadstat#37
but that is an infinite effort.

See https://reproducible-builds.org/ for why this matters.

pull bot pushed a commit to steventam312/cpython that referenced this pull request Aug 1, 2019

bpo-36302: Sort list of sources (pythonGH-12341)
When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output .so files.
Thus without the patch, builds (in disposable VMs) would usually differ.

Without this patch, all callers have to be patched individually
dugsong/libdnet#42
sass/libsass-python#212
tahoe-lafs/pycryptopp#41
yt-project/yt#2206
pyproj4/pyproj#142
pytries/datrie#49
Roche/pyreadstat#37
but that is an infinite effort.

See https://reproducible-builds.org/ for why this matters.

LorenzMende added a commit to LorenzMende/cpython that referenced this pull request Aug 11, 2019

bpo-36302: Sort list of sources (pythonGH-12341)
When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output .so files.
Thus without the patch, builds (in disposable VMs) would usually differ.

Without this patch, all callers have to be patched individually
dugsong/libdnet#42
sass/libsass-python#212
tahoe-lafs/pycryptopp#41
yt-project/yt#2206
pyproj4/pyproj#142
pytries/datrie#49
Roche/pyreadstat#37
but that is an infinite effort.

See https://reproducible-builds.org/ for why this matters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.