Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Read-only mirror of rockbox' main repository
branch: master

Revert "PictureFlow: Add move callback for buflib allocations"

It's not needed as picture flow has it's own buffer.

This reverts commit 9076b43.

Detailed explanation from Thomas Martiz (thanks!):

buflib buffers can be passed to yielding functions just fine. Problems
only arise if the are concurrent allocations, for example if two threads
allocate from the same context simultaneously or if the callee does it's
own allocations. This can't happen in the pictureflow case, it has it's
own context and a single thread allocating from it.

Therefore the problem isn't yield() itself, but possible concurrent
buflib_alloc() calls that result from the thread switch. This is because
compaction only ever happens on allocation (and not in a backgroud
thread or so).
latest commit 079d7fbb8b
Thomas Jarosch thomasjfox authored
Something went wrong with that request. Please try again.