Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Notification not showing after logging out and log in with different user on the same server #1299

Merged

Conversation

Projects
3 participants
@leonardoaramaki
Copy link
Contributor

commented May 22, 2018

Closes #1298

@leonardoaramaki leonardoaramaki added this to the 2.3.0 milestone May 22, 2018

@leonardoaramaki leonardoaramaki self-assigned this May 22, 2018

@leonardoaramaki leonardoaramaki added this to Desirable in Cycle 05: 05/05 ~ 05/27 via automation May 22, 2018

@filipedelimabrito filipedelimabrito merged commit 5a678af into beta May 22, 2018

4 checks passed

ci/circleci: build-apk Your tests passed on CircleCI!
Details
ci/circleci: build-kotlin-sdk Your tests passed on CircleCI!
Details
ci/circleci: code-analysis Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

Cycle 05: 05/05 ~ 05/27 automation moved this from Desirable to Done May 22, 2018

@filipedelimabrito filipedelimabrito deleted the fix/notification-not-showing-when-changing-users branch May 22, 2018

@@ -134,6 +134,10 @@ class MainActivity : AppCompatActivity(), MainView, HasActivityInjector, HasSupp
.show()
}

override fun invalidateToken(token: String) {
InstanceID.getInstance(this).deleteToken(token, GoogleCloudMessaging.INSTANCE_ID_SCOPE)

This comment has been minimized.

Copy link
@luciofm

luciofm May 23, 2018

Contributor

If a user has more than one account, this would remove his token for other accounts also, dont?

This comment has been minimized.

Copy link
@leonardoaramaki

leonardoaramaki May 23, 2018

Author Contributor

No, It will invalidate just that specific token.

This comment has been minimized.

Copy link
@leonardoaramaki

leonardoaramaki May 23, 2018

Author Contributor

Actually, although the above is true, we're currently sharing the same token among different servers. I think when logging out and changing servers I think it will automatically refresh the token.

@luciofm

This comment has been minimized.

Copy link
Contributor

commented May 23, 2018

@leonardoaramaki

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2018

Why?

@leonardoaramaki

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2018

@luciofm Please refer to this PR -> #1300
It separates token for multiple accounts (although they seem to be the same).
I was thinking ahead, it's not yet merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.