Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Issue with Github Two-Factor Authentication #1163

Open
LostCatalyst opened this Issue Mar 30, 2019 · 5 comments

Comments

Projects
None yet
6 participants
@LostCatalyst
Copy link

LostCatalyst commented Mar 30, 2019

My Setup

  • Operating System: Windows 10
  • App Version: 2.15.1
  • Installation type:
  • I have tested with the latest version
  • I can simulate the issue easily

Description

The app errors when attempting to sign in from a GitHub account secured with two-factor authentication

Current Behavior

Attempting to sign into a new server using a 2-factor authenticated github account. Successfully enter login name and password. Screen then moves to the next screen asking for the two-factor authentication password. Before I even have a chance to input the password the whole process errors and the screen immediately states connection to server failure.

Expected Behavior

I should be able to enter my two-factor password and login successfully.

@itchison

This comment has been minimized.

Copy link

itchison commented Mar 31, 2019

This issue is not present on the 2.14.7 client.

@tassoevan

This comment has been minimized.

Copy link
Contributor

tassoevan commented Mar 31, 2019

I couldn't reproduce it with 2.15.1. @LostCatalyst, are you using multiple servers?

@cvarjao

This comment has been minimized.

Copy link

cvarjao commented Apr 1, 2019

@tassoevan , yes. We have multiple servers. We are hosting RocketChat and MongoDB in OpenShift with minimum of 3 replicas each. We are also using Custom OAuth configuration to integrate with Keycloak which in turn integrates with GitHub.

@filiy

This comment has been minimized.

Copy link

filiy commented Apr 1, 2019

Yes I believe the issue is more around Custom OAuth with redirect login style and 2.15.1

image

@fspijkerman

This comment has been minimized.

Copy link

fspijkerman commented Apr 16, 2019

Yes I believe the issue is more around Custom OAuth with redirect login style and 2.15.1

I believe so too, I'm having the same issue.
I'm using Keycloak in combination with 2FA, when changing the Login Style from Redirect to Popup it works again. My Rocketchat is a single server setup running in docker.

@tassoevan tassoevan added this to the Short-term milestone Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.