New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of png for server list icon #549

Open
geekgonecrazy opened this Issue Sep 25, 2017 · 6 comments

Comments

Projects
None yet
6 participants
@geekgonecrazy
Member

geekgonecrazy commented Sep 25, 2017

Currently limited to svg. It should take png as well

My Setup

  • Operating System: All
  • App Version: 2.9.0
  • I have tested with the latest version
  • I can simulate the issue easily

Description

If you use png server icon in server list is default icon

Current Behavior

If you use png server icon in server list is default icon

Expected Behavior

It should show the icon uploaded on the server into the logo asset

@pepkaro

This comment has been minimized.

pepkaro commented Oct 6, 2017

Hey there! I can give this a shot.

@gdelavald

This comment has been minimized.

Contributor

gdelavald commented Oct 6, 2017

@pepkaro Awesome, if you need any help make sure to hit #desktop on open.rocket.chat to find us.

@abhishek71994

This comment has been minimized.

abhishek71994 commented Oct 9, 2017

@pepkaro you working on this? otherwise, I'd like to give this a shot.

@pepkaro

This comment has been minimized.

pepkaro commented Oct 10, 2017

Please go for it! I got pulled into other tasks this weekend and haven't started.

@j-kon

This comment has been minimized.

j-kon commented Oct 29, 2017

if you need any help make sure to hit #desktop on open.rocket.chat to find us.

@james007aonderson

This comment has been minimized.

james007aonderson commented Oct 31, 2017

@gdelavald please review #8735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment