diff --git a/packages/rocketchat-lib/server/functions/settings.js b/packages/rocketchat-lib/server/functions/settings.js index cef8a2d960e6..8bed7e4c383d 100644 --- a/packages/rocketchat-lib/server/functions/settings.js +++ b/packages/rocketchat-lib/server/functions/settings.js @@ -74,6 +74,9 @@ RocketChat.settings.add = function(_id, value, options = {}) { if (hiddenSettings[_id] != null) { options.hidden = true; } + if (options.autocomplete == null) { + options.autocomplete = true; + } if (typeof process !== 'undefined' && process.env && process.env[`OVERWRITE_SETTING_${ _id }`]) { let value = process.env[`OVERWRITE_SETTING_${ _id }`]; if (value.toLowerCase() === 'true') { diff --git a/packages/rocketchat-lib/server/startup/settings.js b/packages/rocketchat-lib/server/startup/settings.js index 9b0904c01a34..ed8ca9ab7d18 100644 --- a/packages/rocketchat-lib/server/startup/settings.js +++ b/packages/rocketchat-lib/server/startup/settings.js @@ -1006,12 +1006,14 @@ RocketChat.settings.addGroup('Email', function() { this.add('SMTP_Username', '', { type: 'string', env: true, - i18nLabel: 'Username' + i18nLabel: 'Username', + autocomplete: false }); this.add('SMTP_Password', '', { type: 'password', env: true, - i18nLabel: 'Password' + i18nLabel: 'Password', + autocomplete: false }); this.add('From_Email', '', { type: 'string', diff --git a/packages/rocketchat-ui-admin/client/admin.html b/packages/rocketchat-ui-admin/client/admin.html index caeb39260959..b3ebf3a57ec0 100644 --- a/packages/rocketchat-ui-admin/client/admin.html +++ b/packages/rocketchat-ui-admin/client/admin.html @@ -56,25 +56,25 @@ {{#if multiline}} {{else}} - + {{/if}} {{/if}} {{#if $eq type 'relativeUrl'}} - + {{/if}} {{#if $eq type 'password'}} - + {{/if}} {{#if $eq type 'int'}} - + {{/if}} {{#if $eq type 'boolean'}} - - + + {{/if}} {{#if $eq type 'select'}} @@ -103,7 +103,7 @@ {{/if}} {{#if $eq editor 'expression'}}
- +
{{/if}}
@@ -118,7 +118,7 @@ {{/if}} {{#if $eq type 'font'}} - + {{/if}} {{#if $eq type 'code'}} @@ -143,7 +143,7 @@ {{#if hasChanges section}} {{_ "Save_to_enable_this_action"}} {{else}} - + {{/if}} {{/if}} diff --git a/packages/rocketchat-ui-admin/client/admin.js b/packages/rocketchat-ui-admin/client/admin.js index 645de8e8b588..5553324ade1c 100644 --- a/packages/rocketchat-ui-admin/client/admin.js +++ b/packages/rocketchat-ui-admin/client/admin.js @@ -191,6 +191,13 @@ Template.admin.helpers({ }; } }, + canAutocomplete() { + if (this.autocomplete === false) { + return { + autocomplete: 'off' + }; + } + }, hasChanges(section) { const group = FlowRouter.getParam('group'); const query = {