Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security patch regression #1990

Closed
Sing-Li opened this issue Jan 20, 2016 · 4 comments · Fixed by #2953
Closed

fix security patch regression #1990

Sing-Li opened this issue Jan 20, 2016 · 4 comments · Fixed by #2953

Comments

@Sing-Li
Copy link
Member

@Sing-Li Sing-Li commented Jan 20, 2016

Recent changes have caused regression.

screen shot 2016-01-20 at 9 35 32 am

@engelgabriel

This comment has been minimized.

Copy link
Member

@engelgabriel engelgabriel commented Feb 22, 2016

We should have a blacklist of IPs and domains for the previews

@samhocevar

This comment has been minimized.

Copy link

@samhocevar samhocevar commented Apr 13, 2016

This is tagged security, but there is no description of the bug. How does this affect users?

@engelgabriel

This comment has been minimized.

Copy link
Member

@engelgabriel engelgabriel commented Apr 13, 2016

If you have a web service running on the same machine as Rocket.Chat, that does't have password, and a user sends a message with a URL like https://localhost:3000 the system will do a HTTP GET on that address and display the title of the response.

@Sing-Li

This comment has been minimized.

Copy link
Member Author

@Sing-Li Sing-Li commented Apr 13, 2016

👍 or for the security researcher types ....

vulnerability : bot port scanner against the underlying server or virtualization host

Original discovery credit goes to @sinteur (Radically Open Security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.