Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unread mention indicator doesn't always go away until switching channels. #777

Closed
Morgul opened this issue Sep 12, 2015 · 7 comments
Closed
Assignees
Milestone

Comments

@Morgul
Copy link
Contributor

Morgul commented Sep 12, 2015

I've noticed a few times that the unread mention indicator doesn't always go away once you've read past the mention. In order to clear it, you need to switch channels and switch back.

For reference, this is the indicator I mean:
screen shot 2015-09-12 at 12 31 33 pm

@engelgabriel engelgabriel added this to the v1.1 milestone Sep 12, 2015
@Morgul
Copy link
Contributor Author

Morgul commented Sep 12, 2015

Some additional information. The text stays bold as if there's new messages as well; those seem likely to be caused by the same bug.

I seem to be able to trigger this consistently by being in another tab in Chrome, having someone say something in channel, and then come back to it.

@rodrigok
Copy link
Member

@Morgul, I did some changes related to messages loading and how the mark as read works, can you verify if this issue still occurs for you?

@Morgul
Copy link
Contributor Author

Morgul commented Sep 14, 2015

@rodrigok Are the changes in a branch somewhere, or have they been merged? (I haven't had a chance to setup a dev instance yet, so I've just been testing with the auto built docker.)

@rodrigok
Copy link
Member

@Morgul the changes are in the branch master:

199f45b
a96095c

@marceloschmidt
Copy link
Member

Probably related to #523

@Morgul
Copy link
Contributor Author

Morgul commented Sep 17, 2015

@rodrigok Sorry it took so long for me to getting to test this; work has been a bit insane. But, I can no longer seem to reproduce this.

Seems like those fixes work.

@rodrigok
Copy link
Member

@Morgul nice, there is a lot of issues with the unread mark, bar and "mark as read", we are trying to improve and find the best behavior 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants