Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Application crashing on startup when trying to log errors to `exceptions` channel #10934

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
4 participants
@sampaiodiego
Copy link
Member

sampaiodiego commented May 29, 2018

Closes #10899

Registering the error handler after Mateor.startup will not prevent errors from happening but if one is using Log exceptions to channel feature it will show where exactly the error is happening instead of trying to send a message before the whole server is up and then blaming Apps like the msg bellow (the following error was caused intentionally by adding a throw 'anything' at any place):

image

I have done additional changes to the file, but the only important one to fix the issue is the Meteor.startup() wrap

@rodrigok rodrigok changed the title [FIX] Prevent sending messages to exception channel before startup [FIX] Application crashing on startup when trying to log errors to `exceptions` channel May 29, 2018

@rodrigok rodrigok merged commit 058864a into develop May 29, 2018

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog Your tests passed on CircleCI!
Details
ci/circleci: test-without-oplog Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rodrigok rodrigok deleted the prevent-sending-exceptions-to-channel-before-startup branch May 29, 2018

sampaiodiego added a commit that referenced this pull request May 30, 2018

Merge pull request #10934 from RocketChat/prevent-sending-exceptions-…
…to-channel-before-startup

[FIX] Application crashing on startup when trying to log errors to `exceptions` channel

engelgabriel added a commit that referenced this pull request Jun 4, 2018

Merge branch 'master' into sync-master
* master:
  Bump version to 0.65.1
  Merge pull request #10940 from RocketChat/fix-livechat-not-loading
  Merge pull request #10934 from RocketChat/prevent-sending-exceptions-to-channel-before-startup
  Merge pull request #10928 from RocketChat/fix-email-notification-link
  Merge pull request #10904 from RocketChat/lazyload-fix-regression
  Merge pull request #10851 from RocketChat/leave-room-bug
  fix search shortcut text
  Display vertical scrollbar on demand

# Conflicts:
#	.docker/Dockerfile
#	.docker/Dockerfile.rhel
#	.sandstorm/sandstorm-pkgdef.capnp
#	.travis/snap.sh
#	HISTORY.md
#	package.json
#	packages/rocketchat-lib/rocketchat.info

@rodrigok rodrigok referenced this pull request Jun 28, 2018

Merged

Release 0.66.0 #11278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.