Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] User mentions #11001

Merged
merged 12 commits into from Jun 12, 2018

Conversation

Projects
4 participants
@vynmera
Copy link
Contributor

commented Jun 4, 2018

Related to #10968

It makes the mentions look nicer, and stand out from normal links (otherwise, one could change their name to an URL and be invisible)
Not sure whether it's a [FIX] or a [NEW], but it's small so I'll pick the former.

Old
2018-06-04_22-25-21

New
2018-06-04_22-24-44

vynmera added some commits Jun 4, 2018

@vynmera vynmera changed the title [FIX] Nice mentions [FIX] Nicer, more noticable mentions Jun 4, 2018

vynmera added some commits Jun 4, 2018

@@ -598,6 +598,10 @@ input:-webkit-autofill {
}

.mention-link {
&:not(.mention-link-me):not(.mention-link-all) {

This comment has been minimized.

Copy link
@engelgabriel

engelgabriel Jun 12, 2018

Member

@karlprieb @ggazzo do we need this? or till the more specific selector class="mention-link mention-link-me" already overwrite the background colour?

This comment has been minimized.

Copy link
@vynmera

vynmera Jun 12, 2018

Author Contributor

Just tried it, doesn't work :(
2018-06-12_20-01-55

@engelgabriel engelgabriel added this to the 0.66.0 milestone Jun 12, 2018

@engelgabriel engelgabriel added this to Review/QA in June/2018 via automation Jun 12, 2018

vynmera and others added some commits Jun 12, 2018

@ggazzo ggazzo changed the title [FIX] Nicer, more noticable mentions [IMPROVE] User mentions Jun 12, 2018

@ggazzo ggazzo merged commit 0bd6de6 into RocketChat:develop Jun 12, 2018

4 of 5 checks passed

ci/circleci: build-and-test/hold Your job is on hold on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog Your tests passed on CircleCI!
Details
ci/circleci: test-without-oplog Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

June/2018 automation moved this from Review/QA to Closed Jun 12, 2018

@vynmera vynmera deleted the vynmera:nice-mentions branch Jun 12, 2018

@rodrigok rodrigok referenced this pull request Jun 28, 2018

Merged

Release 0.66.0 #11278

@yahesh

This comment has been minimized.

Copy link

commented Jul 6, 2018

Wow, the default now puts light-green text on a light-blue background. Why would anyone think that is an improvement to what it has looked like before?

We fixed that by using this custom CSS for now, but please fix this bad default...

.message .mention-link {
  background-color: @rc-color-button-primary;
  color           : #fff;
}

.message .mention-link:hover {
  color: #fff;
}
@vynmera

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2018

@yahesh Do you have any custom CSS or colors? It seems to look OK on open.rocket.chat...?

@yahesh

This comment has been minimized.

Copy link

commented Jul 6, 2018

@vynmera We use colour-blindness improved status colours, but as far as I can see, none of these should modify @rc-color-button-primary that is used for background-color or @link-font-color that seems to be used for color:

/* Improve colours for colour-blindness */
:root {
  --status-away:              #6db6ff !important;
  --status-busy:              #FF0000 !important;
  --status-invisible:         #004949 !important;
  --status-invisible-sidebar: #004949 !important;
  --status-offline:           #004949 !important;
  --status-online:            #24ff24 !important;
}
@yahesh

This comment has been minimized.

Copy link

commented Jul 6, 2018

We've looked into this some more and as it seems, the corresponding configuration has moved to "Old Colors (minor)" some time ago and is difficult to follow as @link-font-color is set as an expression down there.

@yahesh

This comment has been minimized.

Copy link

commented Jul 6, 2018

We've reverted to the default colour scheme (except for the status colours) to solve this on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.