Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Custom user name field from Custom OAuth #14381

Conversation

@mjovanovic0
Copy link
Contributor

commented May 4, 2019

@RocketChat/core

Closes RocketChat/feature-requests#107

In settings I added new property: Accounts_OAuth_Custom_Name_Field which holds information of field in custom OAuth identity response from which user name should be populated (ex.: fullName)

mjovanovic0 added some commits May 4, 2019

geekgonecrazy and others added some commits May 7, 2019

Update packages/rocketchat-i18n/i18n/en.i18n.json
Renamed field to be more intuitive

Co-Authored-By: mjovanovic0 <milan@jovanovich.net>
@geekgonecrazy

This comment has been minimized.

Copy link
Member

commented May 7, 2019

I've gone ahead and approved, will likely merge after we get 1.0.3 out the door. Thanks!

@rodrigok rodrigok added this to PRs in 1.1.0 Review May 10, 2019

@rodrigok rodrigok moved this from PRs to PR 1.1.0 in 1.1.0 Review May 15, 2019

@rodrigok rodrigok moved this from PR Backlog to Approved in 1.1.0 Review May 15, 2019

@rodrigok rodrigok merged commit 96afb0b into RocketChat:develop May 15, 2019

4 of 5 checks passed

ci/circleci: build-and-test/hold Your job is on hold on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog-mongo-3-2 Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog-mongo-4-0 Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

1.1.0 Review automation moved this from Approved to Done May 15, 2019

@sampaiodiego sampaiodiego referenced this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.