[FIX] Resolve 'app already exists' error on app update #17544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'Apps' and 'Marketplace' admin pages were using the function `installApp` from the `AppClientOrchestrator` class instead of `updateApp` to update apps. As a result, the 'app already exists' error was being thrown and apps were not being updated.
shiqimei
reviewed
May 7, 2020
As the `install app` handle is only needed in the marketplace page, there's no need to have it in the apps admin page.
ggazzo
approved these changes
May 12, 2020
ggazzo
changed the title
ggazzo
added a commit
that referenced
this pull request
May 12, 2020
…to remove-get-dom * 'remove-get-dom' of github.com:RocketChat/Rocket.Chat: [FIX] Notification sounds (#17616) [FIX] Resolve 'app already exists' error on app update (#17544) [NEW] Unread bars on sidebar (#16862) [FIX] Relative image path in oembededUrlWidget (#15902) Regression: Do not show custom status inside sequential messages (#17613)
gabriellsh
added a commit
that referenced
this pull request
May 13, 2020
… integrations * 'integrations' of github.com:RocketChat/Rocket.Chat: [NEW] Add Permissions to deal with Omnichannel visitor past chats history (#17580) [NEW] Add permissions to deal with Omnichannel custom fields (#17567) [FIX] Livechat iframe allow microphone and camera (#9956) [FIX] Do not allow passwords on private channels (#15642) [FIX] Mail Messages > Cannot mail own user. (#17625) [FIX] remove multiple options from dontAskMeAgain (#17514) [FIX] Notification sounds (#17616) [FIX] Resolve 'app already exists' error on app update (#17544) [NEW] Unread bars on sidebar (#16862) [FIX] Relative image path in oembededUrlWidget (#15902) Regression: Do not show custom status inside sequential messages (#17613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Apps' and 'Marketplace' admin pages were using the function
installAppfrom theAppClientOrchestratorclass instead ofupdateApptoupdate apps. As a result, the 'app already exists' error was being thrown and
apps were not being updated.