New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Changes on department agents should mark form as dirty #19640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
requested review from
a team
and removed request for
renatobecker
December 8, 2020 21:24
@rafaelblink can you, please, fix the conflicts here? |
renatobecker
changed the title
[FIX] Omnichannel - Departments' agents aren't at form validation.
[FIX] Omnichannel department agents aren't at form validation
Jan 6, 2021
@renatobecker do you still need the fix present in this PR? I can handle the conflicts to push it! |
dougfabris
previously approved these changes
Dec 20, 2021
KevLehman
approved these changes
Dec 21, 2021
KevLehman
changed the title
[FIX] Omnichannel department agents aren't at form validation
[FIX] Changes on department agents should mark form as dirty
Dec 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Form validation isn't checking if are some new agents or event changes in existing agents to turn the "Save" button clickable, so I created a method to check this.
Issue(s)
How to test or reproduce
Omnichannel - Deparments Page
Edit departments with some agents and try to change the count, order, or even remove some and add, the "save" button won't be able to click.
Screenshots
Types of changes
Checklist
Changelog
Further comments