Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Changes on department agents should mark form as dirty #19640

Merged
merged 10 commits into from Dec 21, 2021

Conversation

rafaelblink
Copy link
Contributor

Proposed changes

Form validation isn't checking if are some new agents or event changes in existing agents to turn the "Save" button clickable, so I created a method to check this.

Issue(s)

How to test or reproduce

Omnichannel - Deparments Page

Edit departments with some agents and try to change the count, order, or even remove some and add, the "save" button won't be able to click.

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@rafaelblink rafaelblink added this to the 3.9.0 milestone Nov 20, 2020
@renatobecker renatobecker modified the milestones: 3.9.0, 3.10.0 Dec 8, 2020
@renatobecker renatobecker requested review from a team and removed request for renatobecker December 8, 2020 21:24
@rafaelblink rafaelblink marked this pull request as ready for review December 8, 2020 23:04
@renatobecker renatobecker modified the milestones: 3.10.0, 3.9.4 Dec 23, 2020
@renatobecker
Copy link
Contributor

@rafaelblink can you, please, fix the conflicts here?

@renatobecker renatobecker modified the milestones: 3.9.4, 3.11.0 Dec 29, 2020
@renatobecker renatobecker modified the milestones: 3.11.0, 3.10.1 Jan 6, 2021
@renatobecker renatobecker changed the title [FIX] Omnichannel - Departments' agents aren't at form validation. [FIX] Omnichannel department agents aren't at form validation Jan 6, 2021
@renatobecker renatobecker modified the milestones: 3.10.1, 3.11.0 Jan 8, 2021
@tassoevan tassoevan modified the milestones: 3.11.0, 3.11.2 Feb 26, 2021
@sampaiodiego sampaiodiego modified the milestones: 3.11.2, 3.13.0 Feb 28, 2021
@renatobecker renatobecker removed this from the 3.13.0 milestone Mar 23, 2021
@dougfabris
Copy link
Member

@renatobecker do you still need the fix present in this PR? I can handle the conflicts to push it!

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@dougfabris dougfabris added this to the 4.3.0 milestone Dec 20, 2021
dougfabris
dougfabris previously approved these changes Dec 20, 2021
@KevLehman KevLehman changed the title [FIX] Omnichannel department agents aren't at form validation [FIX] Changes on department agents should mark form as dirty Dec 21, 2021
@KevLehman KevLehman merged commit 13ab6ea into develop Dec 21, 2021
@KevLehman KevLehman deleted the omnichannel/department-agents-validation branch December 21, 2021 18:56
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants