Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Issues with Safari #19671

Merged
merged 7 commits into from Nov 25, 2020
Merged

Regression: Issues with Safari #19671

merged 7 commits into from Nov 25, 2020

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Nov 24, 2020

Proposed changes

This PR Fixes

  • Mentions
  • Threads
  • Channels

REQUIRES RocketChat/fuselage#334

And probably other issues with heights in safari

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@MartinSchoeler MartinSchoeler requested a review from a team November 24, 2020 20:52
@ggazzo ggazzo merged commit e47a42a into develop Nov 25, 2020
@ggazzo ggazzo deleted the fix-safari branch November 25, 2020 17:17
@sampaiodiego sampaiodiego mentioned this pull request Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants