Release 4.5.4 #24938
Merged
Release 4.5.4 #24938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Force name and email to string If its ever anything but a string. Like an array for example It borks the user list because of the aggregations done to bring in users * Removed force to string for email Downstream user creation logic handles this so its safe to let go as is * Log number of values received per attribute * Allow multiple emails Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
AllanPazRibeiro
requested review from
sampaiodiego,
pierre-lehnen-rc and
rodrigok
sampaiodiego
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2022-03-24 · 1 🐛 · 2 👩💻👨💻Engine versions
14.18.36.14.153.6, 4.0, 4.2, 4.4, 5.01.31.0🐛 Bug fixes
👩💻👨💻 Core Team 🤓