chore: use only highlight.js 11.8.0 by MartinSchoeler · Pull Request #35572 · RocketChat/Rocket.Chat

MartinSchoeler · 2025-03-20T19:32:16Z

Proposed changes (including videos or screenshots)

Stops using two different versions of highlight.js, instead uses only the latest one

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1031

Steps to test or reproduce

Send messages with code quotes with code from different languages

Further comments

This pull request updates the highlight.js library in the Rocket.Chat repository from version 9 to 11.8.0. The changes include updating the import paths and language registration logic in apps/meteor/app/markdown/lib/hljs.js to improve maintainability and compatibility with the latest version of highlight.js. Additionally, the import statement for highlight.js styles in apps/meteor/client/startup/startup.ts is updated from 'hljs9/styles/github.css' to 'highlight.js/styles/github.css' to ensure correct dependency usage.

dionisio-bot · 2025-03-20T19:32:21Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is targeting the wrong base branch. It should target 7.7.0, but it targets 7.6.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-03-20T19:32:21Z

⚠️ No Changeset found

Latest commit: 2ce3816

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-03-20T19:42:01Z

PR Preview Action v1.6.1
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35572/
Built to branch `gh-pages` at 2025-04-29 20:27 UTC. Preview will be ready when the GitHub Pages deployment is complete.

codecov · 2025-04-17T16:30:00Z

Codecov Report

Attention: Patch coverage is 10.98266% with 154 lines in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (8ba005e) to head (2ce3816).
Report is 59 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35572      +/-   ##
===========================================
- Coverage    61.17%   61.14%   -0.04%     
===========================================
  Files         3005     3013       +8     
  Lines        71387    71594     +207     
  Branches     16342    16382      +40     
===========================================
+ Hits         43669    43773     +104     
- Misses       24750    24848      +98     
- Partials      2968     2973       +5

Flag	Coverage Δ
e2e	`57.83% <8.87%> (-0.04%)`	⬇️
unit	`75.11% <2.89%> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kody-ai · 2025-04-22T19:02:18Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/app/markdown/lib/hljs.js

julio-rocketchat

Security-wise LGTM. Thanks a lot, @MartinSchoeler

gabriellsh

Colors slightly changed (original on top). I don't think this is a huge deal but could you investigate and/or talk to the product team to discuss this? I also wonder if this should be a chore since the styles are changing.

MartinSchoeler · 2025-04-23T17:08:17Z

Moving this to fix, since the update change some colors

kody-ai · 2025-04-23T17:11:12Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-24T15:01:29Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/client/views/root/lib/codeBlockStyles.ts

kody-ai · 2025-04-28T14:17:10Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-29T20:21:05Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-29T21:12:42Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

MartinSchoeler added this to the 7.7.0 milestone Apr 17, 2025

dionisio-bot bot added the stat: conflict label Apr 17, 2025

dionisio-bot bot added stat: conflict and removed stat: conflict labels Apr 22, 2025

kody-ai bot reviewed Apr 22, 2025

View reviewed changes

apps/meteor/app/markdown/lib/hljs.js Show resolved Hide resolved

MartinSchoeler added 2 commits April 22, 2025 16:10

chore: stop using highlight.js 9.18.5

7f712b1

test: update tests to use new return

fff9e6d

MartinSchoeler force-pushed the chore/highlight-update branch from 6ddcb26 to fff9e6d Compare April 22, 2025 19:10

dionisio-bot bot removed the stat: conflict label Apr 22, 2025

julio-rocketchat previously approved these changes Apr 23, 2025

View reviewed changes

MartinSchoeler marked this pull request as ready for review April 23, 2025 12:03

MartinSchoeler requested review from a team as code owners April 23, 2025 12:03

gabriellsh requested changes Apr 23, 2025

View reviewed changes

MartinSchoeler changed the title ~~chore: update hljs9 to highlight.js 11.8.0~~ fix: update hljs9 to highlight.js 11.8.0 Apr 23, 2025

MartinSchoeler changed the title ~~fix: update hljs9 to highlight.js 11.8.0~~ fix: use only highlight.js 11.8.0 Apr 23, 2025

Create proud-rocks-destroy.md

080e8e8

MartinSchoeler dismissed julio-rocketchat’s stale review via 080e8e8 April 23, 2025 17:11

fix: CSS issue

7553ead

kody-ai bot reviewed Apr 24, 2025

View reviewed changes

apps/meteor/client/views/root/lib/codeBlockStyles.ts Outdated Show resolved Hide resolved

MartinSchoeler requested a review from gabriellsh April 24, 2025 18:32

MarcosSpessatto previously approved these changes Apr 24, 2025

View reviewed changes

chore: fix -> chore

8160e8b

MartinSchoeler dismissed MarcosSpessatto’s stale review via 8160e8b April 28, 2025 14:17

MartinSchoeler changed the title ~~fix: use only highlight.js 11.8.0~~ chore: use only highlight.js 11.8.0 Apr 28, 2025

scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Apr 29, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 29, 2025

fix: css order again

bdf178b

fix: specify once again

2ce3816

MarcosSpessatto approved these changes Apr 30, 2025

View reviewed changes

julio-rocketchat approved these changes Apr 30, 2025

View reviewed changes

ggazzo merged commit eaad62b into develop Apr 30, 2025
46 of 48 checks passed

ggazzo deleted the chore/highlight-update branch April 30, 2025 21:20

Comments

Conversation

MartinSchoeler commented Mar 20, 2025 • edited by kody-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-04-29 20:27 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kody-ai bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

julio-rocketchat left a comment

Choose a reason for hiding this comment

Uh oh!

gabriellsh left a comment

Choose a reason for hiding this comment

Uh oh!

MartinSchoeler commented Apr 23, 2025

Uh oh!

kody-ai bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

kody-ai bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MartinSchoeler commented Mar 20, 2025 •

edited by kody-ai bot

Loading

dionisio-bot bot commented Mar 20, 2025 •

edited

Loading

changeset-bot bot commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-04-29 20:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

codecov bot commented Apr 17, 2025 •

edited

Loading

kody-ai bot commented Apr 22, 2025 •

edited

Loading

kody-ai bot commented Apr 23, 2025 •

edited

Loading

kody-ai bot commented Apr 24, 2025 •

edited

Loading

kody-ai bot commented Apr 28, 2025 •

edited

Loading

kody-ai bot commented Apr 29, 2025 •

edited

Loading

kody-ai bot commented Apr 29, 2025 •

edited

Loading